1132464 - Get rid of EventStateManager::GetChildProcessOffset

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

This function is confusing because the name implies it returns an offset but really it returns the refPoint of the provided aEvent, transformed into the child process's root widget coordinate space. i.e. it returns an absolute position and not an offset. It only appears to be used from TabParent which has its own GetChildProcessOffset that *does* return an offset, so we should just switch code over to using that instead.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

This is easier to do once bug 1125040 converts TabParent::GetChildProcessOffset to return a LayoutDeviceIntPoint.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: WIP

Will wait until bug 1125040 lands.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=73a22a074e7a

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8565112 [details] [diff] [review]
Patch

Please test things like context menu handling etc.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Tested various scenarios an in e10s window on OS X, things seem to work fine. The try push is green as well.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f10460c33eb6

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f10460c33eb6