Closed Bug 1132464 Opened 6 years ago Closed 6 years ago

Get rid of EventStateManager::GetChildProcessOffset

Categories

(Core :: DOM: Events, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file, 1 obsolete file)

This function is confusing because the name implies it returns an offset but really it returns the refPoint of the provided aEvent, transformed into the child process's root widget coordinate space. i.e. it returns an absolute position and not an offset. It only appears to be used from TabParent which has its own GetChildProcessOffset that *does* return an offset, so we should just switch code over to using that instead.
This is easier to do once bug 1125040 converts TabParent::GetChildProcessOffset to return a LayoutDeviceIntPoint.
Depends on: 1125040
Attached patch WIP (obsolete) — Splinter Review
Will wait until bug 1125040 lands.
Comment on attachment 8565112 [details] [diff] [review]
Patch

Please test things like context menu handling etc.
Attachment #8565112 - Flags: review?(bugs) → review+
Tested various scenarios an in e10s window on OS X, things seem to work fine. The try push is green as well.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f10460c33eb6
https://hg.mozilla.org/mozilla-central/rev/f10460c33eb6
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.