Closed Bug 1132547 Opened 5 years ago Closed 5 years ago

Move "reader.has_used_toolbar" logic to Android's Reader.js

Categories

(Toolkit :: Reader Mode, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file, 1 obsolete file)

This is only used for Android, not desktop. Let's move it out.
/r/3847 - Bug 1132547 - Move reader.has_used_toolbar logic to Android's Reader.js. r=bnicholson

Pull down this commit:

hg pull review -r 6c3e57259a0dc4a70222fa2fdf4aa1c5b823f93c
Attachment #8564281 - Flags: review?(bnicholson)
https://reviewboard.mozilla.org/r/3847/#review3069

::: toolkit/components/reader/AboutReader.jsm
(Diff revision 1)
> -  _setBrowserToolbarVisiblity: function Reader_setBrowserToolbarVisiblity(visible) {

This method is unused as of bug 1111142, so I decided to just remove it (and all its associated plumbing). This was only used to hide the toolbar when double-tapping to scroll the page. Techincally, that functionality is regressed, but I kinda want to just get rid of that, since it's not an obvious feature, and its implementation is kinda hacky.
See also: bug 1132763. Hiding the system UI is just broken right now :/
Comment on attachment 8564281 [details]
MozReview Request: bz://1132547/margaret

https://reviewboard.mozilla.org/r/3845/#review3109
Attachment #8564281 - Flags: review?(bnicholson) → review+
https://hg.mozilla.org/mozilla-central/rev/a288bf86a785
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Attachment #8564281 - Attachment is obsolete: true
Attachment #8619431 - Flags: review+
You need to log in before you can comment on or make changes to this bug.