1132547 - Move "reader.has_used_toolbar" logic to Android's Reader.js

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect)

Description

[:Margaret Leibovic]

This is only used for Android, not desktop. Let's move it out.

Comment 1

[:Margaret Leibovic]

Attachment: MozReview Request: bz://1132547/margaret

/r/3847 - Bug 1132547 - Move reader.has_used_toolbar logic to Android's Reader.js. r=bnicholson

Pull down this commit:

hg pull review -r 6c3e57259a0dc4a70222fa2fdf4aa1c5b823f93c

Comment 2

[:Margaret Leibovic]

https://reviewboard.mozilla.org/r/3847/#review3069

::: toolkit/components/reader/AboutReader.jsm
(Diff revision 1)
> -  _setBrowserToolbarVisiblity: function Reader_setBrowserToolbarVisiblity(visible) {

This method is unused as of bug 1111142, so I decided to just remove it (and all its associated plumbing). This was only used to hide the toolbar when double-tapping to scroll the page. Techincally, that functionality is regressed, but I kinda want to just get rid of that, since it's not an obvious feature, and its implementation is kinda hacky.

Comment 3

[:Margaret Leibovic]

See also: bug 1132763. Hiding the system UI is just broken right now :/

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8564281 [details]
MozReview Request: bz://1132547/margaret

https://reviewboard.mozilla.org/r/3845/#review3109

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/a288bf86a785

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a288bf86a785

Comment 8

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1132547 - Move reader.has_used_toolbar logic to Android's Reader.js. r=bnicholson