1132562 - Use a sub directory of the volume mounted folder to run builds...

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[James Lal [:lightsofapollo]]

Deleting entire objddir directory can cause issues like this http://docs.taskcluster.net/tools/task-inspector/#rVssl1EoSROD4_AZHz6QBA/0

Comment 1

[James Lal [:lightsofapollo]]

Attachment: MozReview Request: bz://1132562/lightsofapollo

/r/4225 - Bug 1132562 - Use workspace directory so autoclobber can function with caches r=wcosta
/r/4227 - Bug 1131157 - Add buildbot lines to mulet/b2g-desktop/emulator r=wcosta
/r/4229 - Bug 1136020 - Update try decision task to use cache and more recent version of builder r=garndt
/r/4231 - Bug 1136026 - Ensure ccache has enough space and is tied to specific caches r=wcosta
/r/4233 - Bug 1132676 - Add support for try: appearning anywhere in commit

Pull down these commits:

hg pull review -r b70fecc6f869a6e7159947758184bbfd47f6a975

Comment 2

[James Lal [:lightsofapollo]]

I had a bunch of related work that to a degree depended on each other so I made this one medium size review instead of 5 really tiny ones. I will take care of the paperwork of updating each after review.

Comment 3

[James Lal [:lightsofapollo]]

Try run: https://treeherder.allizom.org/#/jobs?repo=try&revision=c3f0eae70d97

Comment 4

[James Lal [:lightsofapollo]]

Comment on attachment 8568401 [details]
MozReview Request: bz://1132562/lightsofapollo

/r/4225 - Bug 1132562 - Use workspace directory so autoclobber can function with caches r=wcosta
/r/4227 - Bug 1131157 - Add buildbot lines to mulet/b2g-desktop/emulator r=wcosta
/r/4229 - Bug 1136020 - Update try decision task to use cache and more recent version of builder r=garndt
/r/4231 - Bug 1136026 - Ensure ccache has enough space and is tied to specific caches r=wcosta
/r/4233 - Bug 1132676 - Add support for try: appearning anywhere in commit

Pull down these commits:

hg pull review -r 6b5b0c687df6e0636ee753da4756576e33d4333c

Comment 5

[James Lal [:lightsofapollo]]

Few fixes I caught after running tests and looking over everything myself (new try https://treeherder.allizom.org/#/jobs?repo=try&revision=3950538bb158)

Comment 6

[Wander Lairson Costa]

https://reviewboard.mozilla.org/r/4225/#review3403

::: testing/docker/builder/Dockerfile
(Diff revision 2)
> +# Add bin tools last as they are most likely to change

I think this should be at line 29, shouldn't it?

Comment 7

[Wander Lairson Costa]

https://reviewboard.mozilla.org/r/4227/#review3405

::: testing/taskcluster/tasks/builds/mulet_linux.yml
(Diff revision 2)
> +        buildbot_step 'Build' ./build-mulet-linux.sh $HOME/workspace

I think this commit can be squashed with commit c967bafe

Comment 8

[Wander Lairson Costa]

Comment on attachment 8568401 [details]
MozReview Request: bz://1132562/lightsofapollo

https://reviewboard.mozilla.org/r/4223/#review3407

Ship It!

Comment 9

[Wander Lairson Costa]

Two nits, but lgtm

Comment 10

[Greg Arndt [:garndt]]

(In reply to James Lal [:lightsofapollo] from comment #5)
> Few fixes I caught after running tests and looking over everything myself
> (new try
> https://treeherder.allizom.org/#/jobs?repo=try&revision=3950538bb158)

Hrm, looks like for some reason the build for "B2G KK Emulator opt" did upload any of its build artifacts causing all test runs to fail.

Comment 11

[James Lal [:lightsofapollo]]

Looks like kk is fine https://treeherder.allizom.org/#/jobs?repo=try&revision=4c717ed3bd7b I think I posted wrong commit.

Comment 12

[Greg Arndt [:garndt]]

Comment on attachment 8568401 [details]
MozReview Request: bz://1132562/lightsofapollo

r+ with the following:

Looks like branch.yml needs to be updated to use workspaces and to not use a file that is no long available in the builder image with these changes (testing/docker/builder/bin/decision.sh).  Really we could probably just point the config in mozilla-taskcluster at try.yml for everything.  the mach command knows what to do.

Looked over the code and checked out both try revisions to compare results.

Comment 13

[Greg Arndt [:garndt]]

Spoke to James on irc, my comment above doesn't need to be addressed with this bug and since the branch.yml looks at the older builder version, necessary files should still be in place.

Comment 14

[James Lal [:lightsofapollo]]

https://hg.mozilla.org/integration/b2g-inbound/rev/5146a53beb77

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5146a53beb77

Comment 17

[James Lal [:lightsofapollo]]

Attachment: MozReview Request: Bug 1132562 - Use workspace directory so autoclobber can function with caches r=wcosta

Comment 18

[James Lal [:lightsofapollo]]

Attachment: MozReview Request: Bug 1131157 - Add buildbot lines to mulet/b2g-desktop/emulator r=wcosta

Comment 19

[James Lal [:lightsofapollo]]

Attachment: MozReview Request: Bug 1136026 - Ensure ccache has enough space and is tied to specific caches r=wcosta

Comment 20

[James Lal [:lightsofapollo]]

Attachment: MozReview Request: Bug 1136020 - Update try decision task to use cache and more recent version of builder r=garndt

Comment 21

[James Lal [:lightsofapollo]]

Attachment: MozReview Request: Bug 1132676 - Add support for try: appearning anywhere in commit

Comment 22

[Pete Moore [:pmoore][:pete]]

Resetting Version and Target Milestone that accidentally got changed...