Closed Bug 1132562 Opened 5 years ago Closed 5 years ago

Use a sub directory of the volume mounted folder to run builds...

Categories

(Taskcluster :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jlal, Assigned: jlal)

References

Details

Attachments

(5 files, 1 obsolete file)

Deleting entire objddir directory can cause issues like this http://docs.taskcluster.net/tools/task-inspector/#rVssl1EoSROD4_AZHz6QBA/0
Assignee: nobody → jlal
/r/4225 - Bug 1132562 - Use workspace directory so autoclobber can function with caches r=wcosta
/r/4227 - Bug 1131157 - Add buildbot lines to mulet/b2g-desktop/emulator r=wcosta
/r/4229 - Bug 1136020 - Update try decision task to use cache and more recent version of builder r=garndt
/r/4231 - Bug 1136026 - Ensure ccache has enough space and is tied to specific caches r=wcosta
/r/4233 - Bug 1132676 - Add support for try: appearning anywhere in commit

Pull down these commits:

hg pull review -r b70fecc6f869a6e7159947758184bbfd47f6a975
Attachment #8568401 - Flags: review?(wcosta)
Attachment #8568401 - Flags: review?(garndt)
I had a bunch of related work that to a degree depended on each other so I made this one medium size review instead of 5 really tiny ones. I will take care of the paperwork of updating each after review.
Comment on attachment 8568401 [details]
MozReview Request: bz://1132562/lightsofapollo

/r/4225 - Bug 1132562 - Use workspace directory so autoclobber can function with caches r=wcosta
/r/4227 - Bug 1131157 - Add buildbot lines to mulet/b2g-desktop/emulator r=wcosta
/r/4229 - Bug 1136020 - Update try decision task to use cache and more recent version of builder r=garndt
/r/4231 - Bug 1136026 - Ensure ccache has enough space and is tied to specific caches r=wcosta
/r/4233 - Bug 1132676 - Add support for try: appearning anywhere in commit

Pull down these commits:

hg pull review -r 6b5b0c687df6e0636ee753da4756576e33d4333c
Few fixes I caught after running tests and looking over everything myself (new try https://treeherder.allizom.org/#/jobs?repo=try&revision=3950538bb158)
https://reviewboard.mozilla.org/r/4225/#review3403

::: testing/docker/builder/Dockerfile
(Diff revision 2)
> +# Add bin tools last as they are most likely to change

I think this should be at line 29, shouldn't it?
https://reviewboard.mozilla.org/r/4227/#review3405

::: testing/taskcluster/tasks/builds/mulet_linux.yml
(Diff revision 2)
> +        buildbot_step 'Build' ./build-mulet-linux.sh $HOME/workspace

I think this commit can be squashed with commit c967bafe
Comment on attachment 8568401 [details]
MozReview Request: bz://1132562/lightsofapollo

https://reviewboard.mozilla.org/r/4223/#review3407

Ship It!
Attachment #8568401 - Flags: review?(wcosta) → review+
Two nits, but lgtm
(In reply to James Lal [:lightsofapollo] from comment #5)
> Few fixes I caught after running tests and looking over everything myself
> (new try
> https://treeherder.allizom.org/#/jobs?repo=try&revision=3950538bb158)

Hrm, looks like for some reason the build for "B2G KK Emulator opt" did upload any of its build artifacts causing all test runs to fail.
Looks like kk is fine https://treeherder.allizom.org/#/jobs?repo=try&revision=4c717ed3bd7b I think I posted wrong commit.
Comment on attachment 8568401 [details]
MozReview Request: bz://1132562/lightsofapollo

r+ with the following:

Looks like branch.yml needs to be updated to use workspaces and to not use a file that is no long available in the builder image with these changes (testing/docker/builder/bin/decision.sh).  Really we could probably just point the config in mozilla-taskcluster at try.yml for everything.  the mach command knows what to do.

Looked over the code and checked out both try revisions to compare results.
Attachment #8568401 - Flags: review?(garndt) → review+
Spoke to James on irc, my comment above doesn't need to be addressed with this bug and since the branch.yml looks at the older builder version, necessary files should still be in place.
https://hg.mozilla.org/mozilla-central/rev/5146a53beb77
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Attachment #8568401 - Attachment is obsolete: true
Attachment #8619432 - Flags: review+
Attachment #8619433 - Flags: review+
Attachment #8619434 - Flags: review+
Attachment #8619435 - Flags: review+
Attachment #8619436 - Flags: review+
Component: TaskCluster → General
Product: Testing → Taskcluster
Target Milestone: mozilla39 → mozilla41
Version: unspecified → Trunk
Resetting Version and Target Milestone that accidentally got changed...
Target Milestone: mozilla41 → ---
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.