Remove separate ExecutableAllocator for Ion code

RESOLVED FIXED in Firefox 38

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla38
Points:
---

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Created attachment 8563561 [details] [diff] [review]
Part 1 - Remove Ion allocator

After bug 1091912, this is no longer necessary and we can use a single allocator for all JIT code.
Attachment #8563561 - Flags: review?(luke)
(Assignee)

Comment 1

3 years ago
Created attachment 8563565 [details] [diff] [review]
Part 2 - Move ExecutableAllocator into JitRuntime

With YARR gone, we only use ExecutableAllocator for JitCode, and JitCodes are only allocated when we have a JitRuntime, so we can simply move ExecutableAllocator into JitRuntime.

This patch also has some minor cleanup.
Attachment #8563565 - Flags: review?(luke)

Comment 2

3 years ago
Comment on attachment 8563561 [details] [diff] [review]
Part 1 - Remove Ion allocator

Review of attachment 8563561 [details] [diff] [review]:
-----------------------------------------------------------------

My favorite kind of review.
Attachment #8563561 - Flags: review?(luke) → review+

Comment 3

3 years ago
Comment on attachment 8563565 [details] [diff] [review]
Part 2 - Move ExecutableAllocator into JitRuntime

Review of attachment 8563565 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.
Attachment #8563565 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/7dc41de40625
https://hg.mozilla.org/mozilla-central/rev/4d4b564c9d84
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Depends on: 1221385
You need to log in before you can comment on or make changes to this bug.