Closed
Bug 1132564
Opened 11 years ago
Closed 11 years ago
Remove separate ExecutableAllocator for Ion code
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla38
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(2 files)
|
8.19 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
|
19.16 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
After bug 1091912, this is no longer necessary and we can use a single allocator for all JIT code.
Attachment #8563561 -
Flags: review?(luke)
| Assignee | ||
Comment 1•11 years ago
|
||
With YARR gone, we only use ExecutableAllocator for JitCode, and JitCodes are only allocated when we have a JitRuntime, so we can simply move ExecutableAllocator into JitRuntime.
This patch also has some minor cleanup.
Attachment #8563565 -
Flags: review?(luke)
Comment 2•11 years ago
|
||
Comment on attachment 8563561 [details] [diff] [review]
Part 1 - Remove Ion allocator
Review of attachment 8563561 [details] [diff] [review]:
-----------------------------------------------------------------
My favorite kind of review.
Attachment #8563561 -
Flags: review?(luke) → review+
Comment 3•11 years ago
|
||
Comment on attachment 8563565 [details] [diff] [review]
Part 2 - Move ExecutableAllocator into JitRuntime
Review of attachment 8563565 [details] [diff] [review]:
-----------------------------------------------------------------
Nice.
Attachment #8563565 -
Flags: review?(luke) → review+
| Assignee | ||
Comment 4•11 years ago
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7dc41de40625
https://hg.mozilla.org/mozilla-central/rev/4d4b564c9d84
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•