Closed Bug 1132592 Opened 5 years ago Closed 5 years ago

In-tree test plugin doesn't render properly with e10s

Categories

(Core :: Plug-ins, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
e10s m5+ ---
firefox38 --- fixed

People

(Reporter: jimm, Assigned: jimm)

Details

Attachments

(2 files, 3 obsolete files)

Attached image plugins.png
The origin is off. This might be a bug in the test plugin, or it might be a bug with e10s.
Look like the clipping is off, not the origin (since the outline is still correct).

Even if this were a "bug" in the testplugin, we'd probably need to make it work correctly in the browser, because all sorts of production systems copy code from our testplugin to get started.
Attachment #8563583 - Attachment description: plguins.png → plugins.png
Attached patch fix (obsolete) — Splinter Review
This fixes the problem. Avoids showing plugin native widgets until they are properly clipped and positioned within the browser window by the compositor.
Attachment #8564155 - Flags: review?(aklotz)
Attached patch fix (obsolete) — Splinter Review
Also, lets update the enabled state when we update the visibility.
Attachment #8564155 - Attachment is obsolete: true
Attachment #8564155 - Flags: review?(aklotz)
Attachment #8564158 - Flags: review?(aklotz)
Attached patch fix (obsolete) — Splinter Review
Sorry for the bugspam, I had a flag reversed in this rev.
Attachment #8564158 - Attachment is obsolete: true
Attachment #8564158 - Flags: review?(aklotz)
Attachment #8564161 - Flags: review?(aklotz)
Attachment #8564161 - Flags: review?(aklotz) → review+
Attached patch patch (r=aklotz)Splinter Review
Attachment #8564161 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/15dea2b0929b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.