Closed
Bug 1132592
Opened 6 years ago
Closed 6 years ago
In-tree test plugin doesn't render properly with e10s
Categories
(Core :: Plug-ins, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: jimm, Assigned: jimm)
Details
Attachments
(2 files, 3 obsolete files)
14.48 KB,
image/png
|
Details | |
3.11 KB,
patch
|
Details | Diff | Splinter Review |
The origin is off. This might be a bug in the test plugin, or it might be a bug with e10s.
Comment 1•6 years ago
|
||
Look like the clipping is off, not the origin (since the outline is still correct). Even if this were a "bug" in the testplugin, we'd probably need to make it work correctly in the browser, because all sorts of production systems copy code from our testplugin to get started.
![]() |
Assignee | |
Updated•6 years ago
|
Attachment #8563583 -
Attachment description: plguins.png → plugins.png
![]() |
Assignee | |
Comment 2•6 years ago
|
||
This fixes the problem. Avoids showing plugin native widgets until they are properly clipped and positioned within the browser window by the compositor.
Attachment #8564155 -
Flags: review?(aklotz)
![]() |
Assignee | |
Comment 3•6 years ago
|
||
Also, lets update the enabled state when we update the visibility.
Attachment #8564155 -
Attachment is obsolete: true
Attachment #8564155 -
Flags: review?(aklotz)
Attachment #8564158 -
Flags: review?(aklotz)
![]() |
Assignee | |
Comment 4•6 years ago
|
||
Sorry for the bugspam, I had a flag reversed in this rev.
Attachment #8564158 -
Attachment is obsolete: true
Attachment #8564158 -
Flags: review?(aklotz)
Attachment #8564161 -
Flags: review?(aklotz)
Updated•6 years ago
|
Attachment #8564161 -
Flags: review?(aklotz) → review+
![]() |
Assignee | |
Comment 5•6 years ago
|
||
Attachment #8564161 -
Attachment is obsolete: true
![]() |
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
![]() |
Assignee | |
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c147196097f
![]() |
Assignee | |
Updated•6 years ago
|
Comment 7•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/15dea2b0929b
Keywords: checkin-needed
Comment 8•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/15dea2b0929b
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•