1132672 - [RTL] [FTE] The icons found on the import contacts page are overlapping the text next to them

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P1)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: FTE Overlap Screenshot

Description:
The user can see icons overlapping the text associated with them when viewing the import contacts page in the First Time User Experience

Prerequisites: Reset the device or have a fresh flash to begin the FTU

Repro Steps:
1) Update a Flame to 20150212010213
2) On the language screen choose Arabic to enable the RTL layout
3) Press next until reaching the Import contacts screen
4) Observe SD card, Facebook, SIM card, Gmail, and Outlook Icons


Actual:
The icons are overlapping the text associated with them


Expected:
There is no overlapping text in the FTE

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150212010213
Gaia: d5a71cedb37dd45f439f672489db3994b349ac43
Gecko: 3094601af679
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 10/10
See attached: Screenshot

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue does NOT occur on Flame 2.2

The icons are visible and not overlapping any text

Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat)(Full Flash)
Build ID: 20150212002504
Gaia: 791e53728cd8018f1d7cf7efe06bbeb1179f0370
Gecko: 5dec207fcbeb
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Dylan Oliver [:doliver]]

[Blocking Requested - why for this release]: Regression in RTL

Comment 3

[Peter Bylenga [:PBylenga]]

Requesting a window

Comment 4

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Bug 1130231 seems to have caused this issue.

Mozilla-inbound Regression Window

Last Working
Environmental Variables:
Device: Flame 3.0
BuildID: 20150209063429
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: c13e7799a147
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

First Broken
Environmental Variables:
Device: Flame 3.0
BuildID: 20150209064732
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: 70a1847bdc20
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Last Working gaia / First Broken gecko - Issue DOES occur
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: 70a1847bdc20

First Broken gaia / Last Working gecko - Issue does NOT occur
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: c13e7799a147

Gecko Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c13e7799a147&tochange=70a1847bdc20

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

Jonathan, can you take a look at this one too please? Looks like the cause might be that same bug 1130231

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] jfkthame:ftu-import-rtl > mozilla-b2g:master

Comment 7

[Jonathan Kew [:jfkthame]]

Comment on attachment 8564510 [details] [review]
[gaia] jfkthame:ftu-import-rtl > mozilla-b2g:master

Similar to the other RTL-padding issues we've been fixing since bug 1130231 landed.

Comment 8

[Jonathan Kew [:jfkthame]]

I expect this will also affect v2.2 once bug 1130231 merges there.

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] anefzaoui:bug-1132672 > mozilla-b2g:master

Comment 10

[Ahmed Nefzaoui [:Nefzaoui]]

Oh! I didn't realize someone is working on this.
Sorry!

Comment 11

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8565055 [details] [review]
[gaia] anefzaoui:bug-1132672 > mozilla-b2g:master

>https://github.com/mozilla-b2g/gaia/pull/28248

Comment 12

[Sam Foster [:sfoster] (PTO until 2026-01-05) (he/him)]

Comment on attachment 8564510 [details] [review]
[gaia] jfkthame:ftu-import-rtl > mozilla-b2g:master

Looks good in both RTL, LRT

Comment 13

[Sam Foster [:sfoster] (PTO until 2026-01-05) (he/him)]

Sry, no info needed

Comment 14

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/115334fcbd3f65c9da8f12fce815a6309cea911d

Comment 15

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is now affecting 2.2 because bug 1130231 has been uplifted to the 2.2 branch.  Can the fix for this be uplifted there as well?


Environmental Variables:
Device: Flame 2.2 KK (319MB) (Full Flash)
BuildID: 20150219002504
Gaia: ce79d35b92261e7cbfeaefebf87859ebeb0979b4
Gecko: 159a3907b959
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 16

[Jonathan Kew [:jfkthame]]

(In reply to Jayme Mercado [:JMercado] from comment #15)
> This issue is now affecting 2.2 because bug 1130231 has been uplifted to the
> 2.2 branch.  Can the fix for this be uplifted there as well?

I think it should be (this was expected, see comment 8), but approval isn't mine to give.

Comment 17

[Sam Foster [:sfoster] (PTO until 2026-01-05) (he/him)]

Comment on attachment 8564510 [details] [review]
[gaia] jfkthame:ftu-import-rtl > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): FTU/RTL
[User impact] if declined: In RTL locales, buttons in the Import Contacts screen in the First Time Experience may be overlapped/misaligned to their labels
[Testing completed]: on device with 2.2   
[Risk to taking this patch] (and alternatives if risky): Minimal, this is a CSS change that affects FTU in RTL locales only. It undoes a workaround made unnecessary by bug 1130231
[String changes made]: None

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/237575a97e1903d28f03fc438064b55c527d843e

Comment 19

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is veried fixed on the latest Nightly Flame 3.0 and 2.2 builds.
	
Actual Results: The icons and text do not overlap.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150224010314
Gaia: 31ac1cd7a029d5e46dd7c92537b5c973c5d9826e
Gecko: 368c62292249
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150224002637
Gaia: 8e98fe665f3821d10d4d982cbb14cbe5b94d0be5
Gecko: 2b70d9d62799
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0