Closed
Bug 1132672
Opened 9 years ago
Closed 9 years ago
[RTL] [FTE] The icons found on the import contacts page are overlapping the text next to them
Categories
(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P1)
Firefox OS Graveyard
Gaia::First Time Experience
ARM
Gonk (Firefox OS)
Tracking
(blocking-b2g:2.5+, b2g-v2.2 verified, b2g-master verified)
People
(Reporter: dharris, Assigned: jfkthame)
References
Details
(Keywords: regression, Whiteboard: [3.0-Daily-Testing])
Attachments
(2 files, 1 obsolete file)
53.93 KB,
image/png
|
Details | |
46 bytes,
text/x-github-pull-request
|
sfoster
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details | Review |
Description: The user can see icons overlapping the text associated with them when viewing the import contacts page in the First Time User Experience Prerequisites: Reset the device or have a fresh flash to begin the FTU Repro Steps: 1) Update a Flame to 20150212010213 2) On the language screen choose Arabic to enable the RTL layout 3) Press next until reaching the Import contacts screen 4) Observe SD card, Facebook, SIM card, Gmail, and Outlook Icons Actual: The icons are overlapping the text associated with them Expected: There is no overlapping text in the FTE Environmental Variables: Device: Flame 3.0 (319mb)(Kitkat)(Full Flash) Build ID: 20150212010213 Gaia: d5a71cedb37dd45f439f672489db3994b349ac43 Gecko: 3094601af679 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 38.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0 Repro frequency: 10/10 See attached: Screenshot
Reporter | ||
Comment 1•9 years ago
|
||
This issue does NOT occur on Flame 2.2 The icons are visible and not overlapping any text Environmental Variables: Device: Flame 2.2 (319mb)(Kitkat)(Full Flash) Build ID: 20150212002504 Gaia: 791e53728cd8018f1d7cf7efe06bbeb1179f0370 Gecko: 5dec207fcbeb Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 37.0a2 (2.2) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
QA Whiteboard: [QAnalyst-Triage?][rtl-impact]
Flags: needinfo?(pbylenga)
Updated•9 years ago
|
Summary: [FTE][Import Contacts] The icons found on the import contacts page are overlapping the text next to them → [RTL] [FTE] The icons found on the import contacts page are overlapping the text next to them
Comment 2•9 years ago
|
||
[Blocking Requested - why for this release]: Regression in RTL
blocking-b2g: --- → 3.0?
Priority: -- → P1
Comment 3•9 years ago
|
||
Requesting a window
QA Whiteboard: [QAnalyst-Triage?][rtl-impact] → [QAnalyst-Triage+][rtl-impact]
Flags: needinfo?(pbylenga)
Keywords: regressionwindow-wanted
Updated•9 years ago
|
QA Contact: jmercado
Comment 4•9 years ago
|
||
Bug 1130231 seems to have caused this issue. Mozilla-inbound Regression Window Last Working Environmental Variables: Device: Flame 3.0 BuildID: 20150209063429 Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec Gecko: c13e7799a147 Version: 38.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0 First Broken Environmental Variables: Device: Flame 3.0 BuildID: 20150209064732 Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec Gecko: 70a1847bdc20 Version: 38.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0 Last Working gaia / First Broken gecko - Issue DOES occur Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec Gecko: 70a1847bdc20 First Broken gaia / Last Working gecko - Issue does NOT occur Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec Gecko: c13e7799a147 Gecko Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c13e7799a147&tochange=70a1847bdc20
QA Whiteboard: [QAnalyst-Triage+][rtl-impact] → [QAnalyst-Triage?][rtl-impact]
Flags: needinfo?(ktucker)
Keywords: regressionwindow-wanted
Comment 5•9 years ago
|
||
Jonathan, can you take a look at this one too please? Looks like the cause might be that same bug 1130231
QA Whiteboard: [QAnalyst-Triage?][rtl-impact] → [QAnalyst-Triage+][rtl-impact]
Flags: needinfo?(ktucker) → needinfo?(jfkthame)
Comment 6•9 years ago
|
||
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8564510 [details] [review] [gaia] jfkthame:ftu-import-rtl > mozilla-b2g:master Similar to the other RTL-padding issues we've been fixing since bug 1130231 landed.
Flags: needinfo?(jfkthame)
Attachment #8564510 -
Flags: review?(sfoster)
Assignee | ||
Comment 8•9 years ago
|
||
I expect this will also affect v2.2 once bug 1130231 merges there.
Comment 9•9 years ago
|
||
Comment 10•9 years ago
|
||
Oh! I didn't realize someone is working on this. Sorry!
Comment 11•9 years ago
|
||
Comment on attachment 8565055 [details] [review] [gaia] anefzaoui:bug-1132672 > mozilla-b2g:master >https://github.com/mozilla-b2g/gaia/pull/28248
Attachment #8565055 -
Attachment is obsolete: true
Comment 12•9 years ago
|
||
Comment on attachment 8564510 [details] [review] [gaia] jfkthame:ftu-import-rtl > mozilla-b2g:master Looks good in both RTL, LRT
Flags: needinfo?(jfkthame)
Attachment #8564510 -
Flags: review?(sfoster) → review+
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 14•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/115334fcbd3f65c9da8f12fce815a6309cea911d
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 15•9 years ago
|
||
This issue is now affecting 2.2 because bug 1130231 has been uplifted to the 2.2 branch. Can the fix for this be uplifted there as well? Environmental Variables: Device: Flame 2.2 KK (319MB) (Full Flash) BuildID: 20150219002504 Gaia: ce79d35b92261e7cbfeaefebf87859ebeb0979b4 Gecko: 159a3907b959 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 37.0a2 (2.2) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Flags: needinfo?(ktucker)
Flags: needinfo?(jfkthame)
Updated•9 years ago
|
Flags: needinfo?(ktucker)
Assignee | ||
Comment 16•9 years ago
|
||
(In reply to Jayme Mercado [:JMercado] from comment #15) > This issue is now affecting 2.2 because bug 1130231 has been uplifted to the > 2.2 branch. Can the fix for this be uplifted there as well? I think it should be (this was expected, see comment 8), but approval isn't mine to give.
Flags: needinfo?(jfkthame)
Comment 17•9 years ago
|
||
Comment on attachment 8564510 [details] [review] [gaia] jfkthame:ftu-import-rtl > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): FTU/RTL [User impact] if declined: In RTL locales, buttons in the Import Contacts screen in the First Time Experience may be overlapped/misaligned to their labels [Testing completed]: on device with 2.2 [Risk to taking this patch] (and alternatives if risky): Minimal, this is a CSS change that affects FTU in RTL locales only. It undoes a workaround made unnecessary by bug 1130231 [String changes made]: None
Attachment #8564510 -
Flags: approval-gaia-v2.2?
Updated•9 years ago
|
blocking-b2g: 3.0? → 3.0+
Updated•9 years ago
|
Attachment #8564510 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 18•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/237575a97e1903d28f03fc438064b55c527d843e
Assignee: nobody → jfkthame
Target Milestone: --- → 2.2 S6 (20feb)
Comment 19•9 years ago
|
||
This issue is veried fixed on the latest Nightly Flame 3.0 and 2.2 builds. Actual Results: The icons and text do not overlap. Environmental Variables: Device: Flame 3.0 BuildID: 20150224010314 Gaia: 31ac1cd7a029d5e46dd7c92537b5c973c5d9826e Gecko: 368c62292249 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 39.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0 Environmental Variables: Device: Flame 2.2 BuildID: 20150224002637 Gaia: 8e98fe665f3821d10d4d982cbb14cbe5b94d0be5 Gecko: 2b70d9d62799 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 37.0 (2.2) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+][rtl-impact] → [QAnalyst-Triage?][rtl-impact]
Flags: needinfo?(ktucker)
Updated•9 years ago
|
QA Whiteboard: [QAnalyst-Triage?][rtl-impact] → [QAnalyst-Triage+][rtl-impact]
Flags: needinfo?(ktucker)
Updated•9 years ago
|
status-b2g-v2.5:
--- → verified
Updated•9 years ago
|
status-b2g-v2.5:
verified → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•