1132752 - navigator.syncManager.setPolicy generates DataCloneError

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[James Burke [:jrburke]]

When using the latest master flashed today on a flame device, which seems to include the fix for bug 1131963 (no more "SetPolicy matches more than 1 task" error), it shows the following error in the logcat when setPolicy is called:

W/GeckoConsole( 1571): [JavaScript Error: "DataCloneError: The object could not be cloned." {file: "resource://gre/modules/RequestSyncService.jsm" line: 810}]

Test app that can be pushed to device via WebIDE:

https://github.com/jrburke/requestsyncmanager

Set the minInterval secs to another value, and watch the logcat.

Some sync tasks can be generated via this sample app:

https://github.com/jrburke/requestsync

The error does not seem to be fatal, the sync task change seems to still take effect, at least according to the data in a subsequent syncManager.registrations() call.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: rs.patch

So, here the issue is that we store a nsITimer and a list of requestIDs into an object and then we try to save it into IDB. Before setPolicy() that would actually fine because the operation was done when the timer was null. Now this doesn't work anymore.

With this patch, timers and pending requests are stored in 2 separate maps.

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8564044 [details] [diff] [review]
rs.patch

Review of attachment 8564044 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/requestsync/RequestSyncService.jsm
@@ +925,5 @@
> +    if (!(aObj.dbKey in this._pendingRequests)) {
> +      return [];
> +    }
> +
> +    var requests = this._pendingRequests[aObj.dbKey];

nit: s/var/let

Comment 3

[Andrea Marchesini [:baku]]

Attachment: rs.patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 1018320
User impact if declined: RequestSync API will not store tasks correctly into IDB
Testing completed: tbpl
Risk to taking this patch (and alternatives if risky): none
String or UUID changes made by this patch: none

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please provide a Try link.

Comment 5

[Andrea Marchesini [:baku]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e1f154f0341

Comment 6

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8db0046661cb

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8db0046661cb

Comment 8

[Andrea Marchesini [:baku]]

Comment on attachment 8564072 [details] [diff] [review]
rs.patch

It was already approved to land on b2g37.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/9b795d9acc98