1132753 - sdk/l10n/html uses CPOWs and shims

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Dave Townsend [:mossop]]

Since this module is loaded for every single add-on regardless of necessity this makes any and all SDK add-ons cause CPOW jank for every page load :(

Comment 1

[Dave Townsend [:mossop]]

Attachment: pull request

This turns off l10n/html when the add-on has no l10n data.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/83baec9d671b0fba173525e5c4e97b033dacc69d
Bug 1132753: Disable html localisation when the add-on has no l10n data.

https://github.com/mozilla/addon-sdk/commit/6fa2fa6dfa832046816e5dbeac6cc2d0ea3d88d5
Merge pull request #1861 from Mossop/bug1132753

Bug 1132753: Disable html localisation when the add-on has no l10n data. r=jsantell

Comment 3

[Dave Townsend [:mossop]]

Going to keep this bug open as we actually have to fix sdk/l10n/html to support e10s.

Comment 4

[Dave Townsend [:mossop]]

Attachment: pull request

Comment 5

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 8575498 [details] [review]
pull request

I'd like to keep the page-worker test too, otherwise it looks good to me.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/b81b54cf6078fde76ce50b6632e2c13527ee5c1a
Bug 1132753: Fix sdk/l10n/html to not use CPOWs and shims. r=erikvold

This reverts 83baec9d671b0fba173525e5c4e97b033dacc69d which had the
unintentional side-effect of breaking l10n/html in jpm. It also makes the code
that loads locales in test/addons/l10n handle the missing json file in the same
way as sdk/addon/runner.

To get the l10n test add-on working in jpm tests I've moved the en-GB locale to
en-US. This is because of bug 1141696. l10n-properties is still disabled but
that is essentially testing the jpm behaviour in cfx so we shouldn't need to
worry about it.

Splits off the document listening code to run in content processes allowing us
to avoid CPOWs.

Added a test that pages loaded in tabs are localized and copied the entire
l10n add-on to an e10s test add-on so we verify that remote pages are localized
too.