Closed
Bug 1132778
(Fulah-WordPrediction)
Opened 10 years ago
Closed 10 years ago
Add Fulah (ff) wordlist/dictionary
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(blocking-b2g:2.0+, b2g-v2.0 fixed, b2g-v2.0M fixed, b2g-v2.1 fixed, b2g-v2.1S fixed, b2g-v2.2 fixed, b2g-master fixed)
People
(Reporter: delphine, Assigned: rudyl)
References
Details
Attachments
(8 files, 1 obsolete file)
125.75 KB,
application/x-zip-compressed
|
Details | |
46 bytes,
text/x-github-pull-request
|
timdream
:
review+
rudyl
:
feedback+
bajaj
:
approval-gaia-v2.0+
bajaj
:
approval-gaia-v2.1+
bajaj
:
approval-gaia-v2.2+
|
Details | Review |
48.15 KB,
image/png
|
Details | |
56.45 KB,
image/png
|
Details | |
56.80 KB,
image/png
|
Details | |
46 bytes,
text/x-github-pull-request
|
Details | Review | |
46 bytes,
text/x-github-pull-request
|
Details | Review | |
46 bytes,
text/x-github-pull-request
|
Details | Review |
This is a request to add Fulah wordlist/dictionary to Firefox OS.
Locale in Africa are a priority, will update here once we get more specific info. thanks!
Plugging in Ibrahima and Kevin so they may help out with this (amongst others)
Comment 1•10 years ago
|
||
Thanks. I have a wordlist of more than 36,000 words covering many dialects. Adding another dialect and will post here this weekend hopefully.
Reporter | ||
Comment 2•10 years ago
|
||
Hey Ibrahima! Any updates on this please? :D thanks a bunch!
Flags: needinfo?(ibrahima.sarr)
Comment 3•10 years ago
|
||
Hi Delphine
I have been working on a word list and it's probably quite clean now. Should I attach it here or send it to Kevin Scannel§
Flags: needinfo?(ibrahima.sarr)
Comment 4•10 years ago
|
||
Attaching Ibrahima's word list, with frequency data taken from a web corpus with about 2M words (a good bit of that material, not surprisingly, from Ibrahima's web site).
Comment 5•10 years ago
|
||
Wow! I'm speechless. Thanks a million.
Comment 6•10 years ago
|
||
A second version, having filtered out some French words that made their way in.
Attachment #8569882 -
Attachment is obsolete: true
Comment 7•10 years ago
|
||
Awesome, Kevin. Simply awesome... Thumbs!
Reporter | ||
Comment 8•10 years ago
|
||
Thanks so much you guys!
Not sure how to go forwards to implement this anymore....
ni on Bruce so he can maybe help on this part.
Flags: needinfo?(bhuang)
Reporter | ||
Comment 9•10 years ago
|
||
[Blocking Requested - why for this release]:
Also, Fulah committed to on 2.0 for partner. ni on :bajaj to get this on her radar :)
blocking-b2g: --- → 2.0?
Flags: needinfo?(bbajaj)
Comment 10•10 years ago
|
||
Assignee | ||
Comment 11•10 years ago
|
||
Comment on attachment 8571793 [details] [review]
[gaia] RudyLu:keyboard/Bug1132778-Fulah_dictionary > mozilla-b2g:master
Thanks for Ibrahima and Prof. Scannell's help to create the wordlist.
Here is the pull request to check it in and enable the suggestion.
Ibrahima,
If possible, please help give it a try with this patch.
Tim,
Could you please help review this change?
Thanks.
Flags: needinfo?(bhuang)
Attachment #8571793 -
Flags: review?(timdream)
Attachment #8571793 -
Flags: feedback?(ibrahima.sarr)
Updated•10 years ago
|
Attachment #8571793 -
Flags: review?(timdream) → review+
Updated•10 years ago
|
blocking-b2g: 2.0? → 2.0+
Reporter | ||
Comment 12•10 years ago
|
||
Since this has been nom'ed, clearing the ni on :bajaj
Flags: needinfo?(bbajaj)
Comment 13•10 years ago
|
||
Hi
Just back from Mobile World Congress. Sorry then about not responding earlier. Need some guidance on how I can test this. Cheers
Comment 14•10 years ago
|
||
Comment on attachment 8571793 [details] [review]
[gaia] RudyLu:keyboard/Bug1132778-Fulah_dictionary > mozilla-b2g:master
I really don't know what to do here. Any suggestion?
Assignee | ||
Comment 15•10 years ago
|
||
Ibrahima,
Hi, sorry for not replying this in a timely
Do you have a device or b2g desktop to try this out?
If yes, please refer to the following doc to test the newly added keyboard layout and dictionary.
https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Customizing_the_keyboard#Including_a_custom_layout_in_the_Gaia_keyboard_app
In brief,
1. Please help make sure you could build Gaia at your side.
2. add ff layout/dictionary
GAIA_KEYBOARD_LAYOUTS=en,ff make install-gaia
3. Test this on device
Please let me know if you have any other questions.
Thanks.
Flags: needinfo?(ibrahima.sarr)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → rlu
Status: NEW → ASSIGNED
Comment 17•10 years ago
|
||
I don't seem to know how to add the wordlist to gaia. Please help. I am not very good at Gigthub!!
Assignee | ||
Comment 18•10 years ago
|
||
It would be very easy if you already installed "hub",
hub checkout https://github.com/mozilla-b2g/gaia/pull/28588
Please refer to this for how to install this handy tool,
https://hub.github.com/
Thanks.
Flags: needinfo?(ibrahima.sarr)
Comment 19•10 years ago
|
||
Hi Ibrahima, have you tried it yet? Thanks.
Flags: needinfo?(ibrahima.sarr)
Comment 20•10 years ago
|
||
Hi
No, I don't know how to add the wordlist. I need help or some tutorial. The keyboard is there but no wordlist. Thanks
Flags: needinfo?(ibrahima.sarr)
Assignee | ||
Comment 21•10 years ago
|
||
Hi Ibrahima,
If you can help, please try the following steps,
1. Get the dict file from the following link and put into your Gaia folder, apps/keyboard/js/imes/latin/dictionaries
https://github.com/RudyLu/gaia/blob/keyboard/Bug1132778-Fulah_dictionary/apps/keyboard/js/imes/latin/dictionaries/ff.dict
2. Modify ff.js as this,
https://github.com/mozilla-b2g/gaia/pull/28588/files#diff-a57678090663f2c6a8fc73a2930f998e
3. do |make install-gaia|, to see if your device could load the ff dictionary.
Thanks.
Flags: needinfo?(ibrahima.sarr)
Comment 22•10 years ago
|
||
Thank you very much
I have a few questions:
- How do I access folders in Gaia? On the computer I cannot see them.
- The ff.js files say id=fr, is that normal?
We're just a few steps away, I have time to test today if it works.
Flags: needinfo?(ibrahima.sarr)
Assignee | ||
Comment 23•10 years ago
|
||
1. Please start from this doc if you want to build Gaia yourself,
https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Running_the_Gaia_codebase
2. There is no such line "id=fr" in ff.js.
If you saw this from the pull request, it is from the diff view and "id=fr" belongs to the code section below and should be correct.
Thanks for asking!
Flags: needinfo?(ibrahima.sarr)
Reporter | ||
Comment 24•10 years ago
|
||
Hey Arky: seems like Ibrahima is having some trouble to test this. Would you mind helping out if Ibrahima still faces difficulties, maybe by trying this out and taking a look yourself? Wish I could but I honestly won't be of any help here. thanks :)
Flags: needinfo?(hitmanarky)
Comment 25•10 years ago
|
||
I was able to test the pull request (https://github.com/mozilla-b2g/gaia/pull/28588) on Firefox OS device.
Typed the phrase 'Innama aadeeji fof poti, ndimɗidi e jibinannde to bannge hakkeeji. Eɓe ngoodi miijo e hakkilantaagal ete eɓe poti huufo ndirde e nder ɓ iynguyummaagu. (Source: http://www.omniglot.com/writing/fula.htm) into the messaging app.
The autocorrect system correctly suggested autocomplete for following words 'aadeede', 'hakkeeji', 'bannge. There are no visible errors on 'adb logcat'.
Flags: needinfo?(hitmanarky)
Comment 26•10 years ago
|
||
Screenshot of Fullah keyboard dictionary test.
Comment 27•10 years ago
|
||
Screenshot of Fullah keyboard dictionary test.
Comment 28•10 years ago
|
||
Screenshot of Fullah keyboard dictionary test.
Assignee | ||
Comment 29•10 years ago
|
||
Comment on attachment 8571793 [details] [review]
[gaia] RudyLu:keyboard/Bug1132778-Fulah_dictionary > mozilla-b2g:master
Arky,
Thanks for your help!
I would take comment 25 and the screenshots as a f+ for this patch and try to land this soon.
Attachment #8571793 -
Flags: feedback?(ibrahima.sarr) → feedback+
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(ibrahima.sarr)
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 30•10 years ago
|
||
http://docs.taskcluster.net/tools/task-graph-inspector/#XpaYpBZvR22WM5otec9SWQ
The pull request failed to pass integration tests. It could not be landed, please try again.
Comment 31•10 years ago
|
||
(In reply to Rudy Lu [:rudyl] from comment #29)
> Arky,
>
> Thanks for your help!
>
Please kindly NI me for any keyboards/dictionary bugs. I will be happy to assist.
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 32•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/bfe504b49533fb268c5ddda99c606aa66442b313
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 33•10 years ago
|
||
Comment on attachment 8571793 [details] [review]
[gaia] RudyLu:keyboard/Bug1132778-Fulah_dictionary > mozilla-b2g:master
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature
[User impact] if declined: No autocorrection for Fulah (ff) keyboard layout.
[Testing completed]: Yes, manually.
[Risk to taking this patch] (and alternatives if risky): Low, layout/dictionary would not be built unless explicitly set for each branch.
[String changes made]: N/A
Attachment #8571793 -
Flags: approval-gaia-v2.2?
Attachment #8571793 -
Flags: approval-gaia-v2.1?
Attachment #8571793 -
Flags: approval-gaia-v2.0?
Assignee | ||
Comment 34•10 years ago
|
||
This would need specific patches for each branch since the build integration test for keyboard is different on each branch.
Keywords: branch-patch-needed
Updated•10 years ago
|
Attachment #8571793 -
Flags: approval-gaia-v2.2?
Attachment #8571793 -
Flags: approval-gaia-v2.2+
Attachment #8571793 -
Flags: approval-gaia-v2.1?
Attachment #8571793 -
Flags: approval-gaia-v2.1+
Attachment #8571793 -
Flags: approval-gaia-v2.0?
Attachment #8571793 -
Flags: approval-gaia-v2.0+
Comment 35•10 years ago
|
||
Comment 36•10 years ago
|
||
Comment 37•10 years ago
|
||
Comment 38•10 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/2592519a038849ececeacc55042bd1d27d3827c5
v2.1: https://github.com/mozilla-b2g/gaia/commit/87e55a7ec688138812181747f690fd188d2a0668
v2.0: https://github.com/mozilla-b2g/gaia/commit/84898cadf28b1a1fcd03b726cff658de470282f0
status-b2g-v2.0:
--- → fixed
status-b2g-v2.1:
--- → fixed
status-b2g-v2.2:
--- → fixed
status-b2g-master:
--- → fixed
Keywords: branch-patch-needed
Target Milestone: --- → 2.2 S9 (3apr)
Updated•10 years ago
|
status-b2g-v2.0M:
--- → fixed
status-b2g-v2.1S:
--- → fixed
Reporter | ||
Updated•9 years ago
|
Alias: Fulah-WordPrediction
You need to log in
before you can comment on or make changes to this bug.
Description
•