1132795 - Use Carthage for dependency management

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Brian Nicholson (:bnicholson)]

Carthage is a dependency management that works with dynamic frameworks. The long-term goal of Carthage is to build frameworks that can be imported into the project, but there are some issues with building now. For one, several of the projects we're using (KIF, SWXMLHash, and GCDWebServer) don't have shared dynamic frameworks. Secondly, there's a copy-frameworks hack mentioned in https://github.com/Carthage/Carthage that I'd prefer to avoid.

Thankfully, Carthage has a --no-build option that simply pulls in the depencies without trying to build them, which is useful while Carthage is still in its infancy and the build issues are being resolved. Some discussion on --no-build here: https://github.com/Carthage/Carthage/issues/174

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Pull request

Stefan, flagging you since you recommended looking at Carthage and should know how to fix Travis integration. Nick, flagging you since you're usually interested in build-related things!

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8563891 [details] [review]
Pull request

This is good stuff but we have a bunch of issues to work out before we can land this. See the comments on Github. I also filed an issue in the Carthage project to find out how to deal with our more complicated build config.

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8563891 [details] [review]
Pull request

This seems sensible to me.  I will try to get SwiftKeychainWrapper into Carthage, but it may not be the right fit since I want to apply some local modifications.  Perhaps upstream will be interested, or perhaps I (mozilla?) will host the forked repo on GH and we can make that the Carthage endpoint.

I needed to purge my derived data directory, but then my build succeed and all tests passed (including KIF tests, which I had not run before).

Comment 4

[Brian Nicholson (:bnicholson)]

Merged...let's see what happens.