Closed Bug 1132844 Opened 5 years ago Closed 5 years ago

Fix ReaderMode.jsm to work with jsloader.reuseGlobal

Categories

(Toolkit :: Reader Mode, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: fabrice, Assigned: fabrice)

Details

Attachments

(1 file)

I need that for b2g.
Assignee: nobody → fabrice
Attachment #8564025 - Flags: review?(margaret.leibovic)
Comment on attachment 8564025 [details] [diff] [review]
reader-mode-b2g.patch

Review of attachment 8564025 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry I didn't catch that before.

Are you implementing reader mode for b2g?
Attachment #8564025 - Flags: review?(margaret.leibovic) → review+
I'm experimenting with it, yes. But no definitive UX yet!
(In reply to Fabrice Desré [:fabrice] from comment #3)
> I'm experimenting with it, yes. But no definitive UX yet!

Nice. Let me know if you have any questions! Also, bug fixes welcome :D

We actually split the readability bit out into a separate repo so that it can be shared with iOS:
https://github.com/mozilla/readability

It's a few changes ahead of the one in m-c, we should probably get some policy in place about pulling changes into m-c as they land in there.
https://hg.mozilla.org/mozilla-central/rev/fa6ae9d07394
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.