1132845 - [RTL][Calendar]The settings button and reload button change their position.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P3)

Description

[Sue]

Attachment: screenshot.png

[1.Description]:
[RTL][Calendar]When log in an account and tap option menu in Calendar, the settings button and reload button changed there position which should remain the same as that in LTR language.
See attachment:screenshot.png

[2.Testing Steps]: 
Prerequisites: Have your device set to a RTL locale, such as Arabic. Log in an email account
1. Go to Calendar app.
2. Tap options icon.

[3.Expected Result]: 
2. Buttons that are direction-neutral keep their location - so in this case, settings button and reload button on the bottom of page keep their location.

[4.Actual Result]: 
2. Settings button and reload button change their position.

[5.Reproduction build]: 
Flame 2.2 build:
Build ID               20150212002504
Gaia Revision          791e53728cd8018f1d7cf7efe06bbeb1179f0370
Gaia Date              2015-02-11 19:31:02
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5dec207fcbeb
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150212.042208
Firmware Date          Thu Feb 12 04:22:18 EST 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
15240

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] millermedeiros:1132845-rtl-drawer-buttons > mozilla-b2g:master

Comment 2

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8564179 [details] [review]
[gaia] millermedeiros:1132845-rtl-drawer-buttons > mozilla-b2g:master

set [dir="ltr"] on [role="toolbar"] that way order is the same on both locales.. and since it uses flexbox I also had to change the way the border is added in between both buttons.

both are very small changes and very small risk.

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8564179 [details] [review]
[gaia] millermedeiros:1132845-rtl-drawer-buttons > mozilla-b2g:master

LGTM

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/74904acd2c352be5ee77fcf2ca5fab0e7e2cf4e9

Comment 6

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8564179 [details] [review]
[gaia] millermedeiros:1132845-rtl-drawer-buttons > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): none
[User impact] if declined: icons won't follow the RTL UX spec
[Testing completed]: manual
[Risk to taking this patch] (and alternatives if risky): very low risk (changes are isolated and minimal)
[String changes made]: none

Comment 7

[Miller Medeiros [:millermedeiros]]

this blocks calendar-rtl so I think it should be considered a blocker (and be uplifted)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/bac8074e9036ffde1e417521b2d7397f2f92d2b3

Comment 9

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master and 2.2.

Result: The settings icon is on the left, and the reload icon is on the right. 
 
Device: Flame Master (KK, 319mb, full flash)
Build ID: 20150225010244
Gaia: f6bfd854fe4746f21bc006eac145365e85f98808
Gecko: 0a8b3b67715a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150225002505
Gaia: ca64f2fe145909f31af266b1730874051ba76c78
Gecko: 16804008c29f
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 10

[Alissa（leave from Mozilla）]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15911/