1132963 - Automatically detect and redirect to Google doc URLs (akin to github-pr and rb handling)

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Attachment: Sad trombone

This is to request we enable the ability to "Paste as attachment" a Google Doc link and have Bugzilla convert it into an HTTP link. Bonus points if we're able to just paste in the link and use auto-detect.

Comment 1

[:glob ✱]

Attachment: 1132963_1.patch

- refactor "attachment urls that redirect"
- add google docs

note: this won't apply retroactively to any existing attachments.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8565078 [details] [diff] [review]
1132963_1.patch

Review of attachment 8565078 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

(I knew I had done this before: "Restored from draft; last edited 2/16/2015")

::: extensions/BMO/Extension.pm
@@ +778,2 @@
>      return unless
> +        grep { $attachment->contenttype eq $autodetect_attach_urls{$_}->{content_type} }

nit: I'd prefer any { } here.

::: extensions/BMO/lib/Data.pm
@@ +19,4 @@
>                    %product_sec_groups
>                    %create_bug_formats
>                    @default_named_queries
> +                  %autodetect_attach_urls );

this++
I much prefer exporting a hash to another silly constant :)

Comment 3

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   81f9221..2d8badf  master -> master

Comment 4

[:glob ✱]

(In reply to Dylan William Hardison [:dylan] from comment #2)
> > +        grep { $attachment->contenttype eq $autodetect_attach_urls{$_}->{content_type} }
> 
> nit: I'd prefer any { } here.

'any' isn't available in the version of List::Util we have installed :(

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   17f05cd..6da6c66  master -> master