Closed Bug 1133012 Opened 5 years ago Closed 5 years ago

Disable tab mirroring on RELEASE

Categories

(Firefox for Android :: Screencasting, defect)

36 Branch
ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 38
Tracking Status
firefox35 --- wontfix
firefox36 + verified
firefox37 --- verified
firefox38 --- fixed
fennec 36+ ---

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

With Roku still not supported and Chromecast now broken due to a firmware issue, we should consider disabling Tab Mirroring for Fx36.

This patch should be uplifted to Aurora and Beta ASAP.
Attachment #8564299 - Flags: review?(snorp)
Comment on attachment 8564299 [details] [diff] [review]
no-mirroring v0.1

Review of attachment 8564299 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe a comment with the bug# would be helpful, but I don't care much since it's only going on 36.
Attachment #8564299 - Flags: review?(snorp) → review+
[Tracking Requested - why for this release]:
tracking-fennec: --- → ?
OS: Mac OS X → Android
Hardware: x86 → ARM
Version: unspecified → Firefox 36
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #1)
> Comment on attachment 8564299 [details] [diff] [review]
> no-mirroring v0.1
> 
> Review of attachment 8564299 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Maybe a comment with the bug# would be helpful, but I don't care much since
> it's only going on 36.

I'll add the bug number since I plan to land this everywhere. That way we won't forget in two weeks.
Summary: Disable tab mirroring on Fx36 → Disable tab mirroring on RELEASE
Comment on attachment 8564299 [details] [diff] [review]
no-mirroring v0.1

Approval Request Comment
[Feature/regressing bug #]: tracked in bug 1131084
[User impact if declined]: failure to mirror tabs
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: low, limited to tab mirroring
[String/UUID change made/needed]: none
Attachment #8564299 - Flags: approval-mozilla-beta?
Attachment #8564299 - Flags: approval-mozilla-aurora?
Release Note Request (optional, but appreciated)
[Suggested wording]: Chromecast tab mirroring has been temporarily disabled.
Attachment #8564299 - Flags: approval-mozilla-beta?
Attachment #8564299 - Flags: approval-mozilla-beta+
Attachment #8564299 - Flags: approval-mozilla-aurora?
Attachment #8564299 - Flags: approval-mozilla-aurora+
Added to the release notes.
Assignee: nobody → mark.finkle
Actually, marking the release notes in bug 1131084
https://hg.mozilla.org/mozilla-central/rev/ae0ae6c0e1ad
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Verified as fixed in Firefox 36 Beta 10;
Device: Asus Transformer Tab (Android 4.2.1).
tracking-fennec: ? → 36+
Verified as fixed in build 37 Beta 4;
Device: Motorola Razr (Android 4.1.2).
You need to log in before you can comment on or make changes to this bug.