remove SVGSVGElement.{pixel,screenPixel}UnitToMillimeter{X,Y}

RESOLVED FIXED in Firefox 61

Status

()

defect
RESOLVED FIXED
5 years ago
Last year

People

(Reporter: heycam, Assigned: heycam)

Tracking

({dev-doc-complete, site-compat})

Trunk
mozilla61
Points:
---

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch patch (obsolete) — Splinter Review
The SVG WG resolved to remove SVGSVGElement.{pixel,screenPixel}UnitToMillimeter{X,Y} due to lack of use.

r?longsonr for the removal, r?bz for the IDL change DOM peer review.
Attachment #8564476 - Flags: review?(longsonr)
Attachment #8564476 - Flags: review?(bzbarsky)
Attachment #8564476 - Attachment description: rm-pixel → patch
Attachment #8564476 - Attachment is patch: true
Duplicate of this bug: 1133171
Attachment #8564476 - Flags: review?(longsonr) → review+
You should announce this (and the rest of my review queue) on mozilla.dev.platform prior to landing this to give time for anyone to object.

MDN needs updating for all of these changes, this one would be https://developer.mozilla.org/en/docs/Web/API/SVGSVGElement

r=me with that but give the announcement a bit of time as there's no particular rush here is there?
Keywords: dev-doc-needed
Comment on attachment 8564476 [details] [diff] [review]
patch

r=me
Attachment #8564476 - Flags: review?(bzbarsky) → review+
Comment on attachment 8564476 [details] [diff] [review]
patch

Despite its almost certain lack of use I think we should be cautious, announce on the newsgroup and then put this under a pref and disable on nightly only as a first step.
Attachment #8564476 - Flags: review+ → review-
Any update?  These were removed from Chrome two years ago, we saw virtually zero usage and AFAIK heard no issues after removal.

https://groups.google.com/a/chromium.org/d/msg/blink-dev/uJCmB7SzYNo/cBASMfJuBAAJ
https://bugs.chromium.org/p/chromium/issues/detail?id=537177

This is one of a small number of APIs which are not in Chrome but in all other major browsers (a position we generally don't want to be in).
historical test for web-platform-tests: https://github.com/w3c/web-platform-tests/pull/6799
Attachment #8564476 - Flags: review- → review+
The patch is r+ here, but did it actually land?
It did not.
Cameron, any reason not to land this?
Flags: needinfo?(cam)
No, I think I just missed the r+.  I will send a dev-platform mail for completeness.
I think there are WPT changes that would be required now in order to land this. Ie. we will pass some tests that we currently fail.
Assignee: nobody → cam
Attachment #8564476 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e998b6b3f9b0
Remove SVGSVGElement.{pixel,screenPixel}UnitToMillimeter{X,Y}. r=longonsr,bz
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e998b6b3f9b0
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.