1133172 - remove SVGSVGElement.{pixel,screenPixel}UnitToMillimeter{X,Y}

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: patch

The SVG WG resolved to remove SVGSVGElement.{pixel,screenPixel}UnitToMillimeter{X,Y} due to lack of use.

r?longsonr for the removal, r?bz for the IDL change DOM peer review.

Comment 2

[Robert Longson [:longsonr]]

You should announce this (and the rest of my review queue) on mozilla.dev.platform prior to landing this to give time for anyone to object.

MDN needs updating for all of these changes, this one would be https://developer.mozilla.org/en/docs/Web/API/SVGSVGElement

r=me with that but give the announcement a bit of time as there's no particular rush here is there?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8564476 [details] [diff] [review]
patch

r=me

Comment 4

[Robert Longson [:longsonr]]

Comment on attachment 8564476 [details] [diff] [review]
patch

Despite its almost certain lack of use I think we should be cautious, announce on the newsgroup and then put this under a pref and disable on nightly only as a first step.

Comment 5

[Kohei]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-US/docs/2015/getelementbyid-and-several-properties-will-be-removed-from-svgsvgelement/

Comment 6

[Rick Byers]

Any update?  These were removed from Chrome two years ago, we saw virtually zero usage and AFAIK heard no issues after removal.

https://groups.google.com/a/chromium.org/d/msg/blink-dev/uJCmB7SzYNo/cBASMfJuBAAJ
https://bugs.chromium.org/p/chromium/issues/detail?id=537177

This is one of a small number of APIs which are not in Chrome but in all other major browsers (a position we generally don't want to be in).

Comment 7

[Rick Byers]

historical test for web-platform-tests: https://github.com/w3c/web-platform-tests/pull/6799

Comment 8

[Florian Scholz (Open Web Docs)]

The patch is r+ here, but did it actually land?

Comment 9

[Robert Longson [:longsonr]]

It did not.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Cameron, any reason not to land this?

Comment 11

[Cameron McCormack (:heycam)]

No, I think I just missed the r+.  I will send a dev-platform mail for completeness.

Comment 12

[Robert Longson [:longsonr]]

I think there are WPT changes that would be required now in order to land this. Ie. we will pass some tests that we currently fail.

Comment 13

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecb3866cb8d5a7c2d306c89d21a875533d4b56eb

Comment 14

[Cameron McCormack (:heycam)]

Attachment: patch [r=longsonr,bz]

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e998b6b3f9b0
Remove SVGSVGElement.{pixel,screenPixel}UnitToMillimeter{X,Y}. r=longonsr,bz

Comment 16

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e998b6b3f9b0

Comment 17

[Kohei]

Posted the compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/pixelunittomillimeterx-and-similar-properties-have-been-removed-from-svgsvgelement/

Comment 18

[Florian Scholz (Open Web Docs)]

Mentioned removal here:
https://developer.mozilla.org/en-US/Firefox/Releases/61#SVG_2

Compat data on https://developer.mozilla.org/en-US/docs/Web/API/SVGSVGElement#Browser_compatibility will be updated soon:
https://github.com/mdn/browser-compat-data/pull/2014