Closed
Bug 1133172
Opened 8 years ago
Closed 5 years ago
remove SVGSVGElement.{pixel,screenPixel}UnitToMillimeter{X,Y}
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(1 file, 1 obsolete file)
3.97 KB,
patch
|
Details | Diff | Splinter Review |
The SVG WG resolved to remove SVGSVGElement.{pixel,screenPixel}UnitToMillimeter{X,Y} due to lack of use. r?longsonr for the removal, r?bz for the IDL change DOM peer review.
Attachment #8564476 -
Flags: review?(longsonr)
Attachment #8564476 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•8 years ago
|
Attachment #8564476 -
Attachment description: rm-pixel → patch
Attachment #8564476 -
Attachment is patch: true
Updated•8 years ago
|
Attachment #8564476 -
Flags: review?(longsonr) → review+
Comment 2•8 years ago
|
||
You should announce this (and the rest of my review queue) on mozilla.dev.platform prior to landing this to give time for anyone to object. MDN needs updating for all of these changes, this one would be https://developer.mozilla.org/en/docs/Web/API/SVGSVGElement r=me with that but give the announcement a bit of time as there's no particular rush here is there?
Keywords: dev-doc-needed
![]() |
||
Comment 3•8 years ago
|
||
Comment on attachment 8564476 [details] [diff] [review] patch r=me
Attachment #8564476 -
Flags: review?(bzbarsky) → review+
Comment 4•8 years ago
|
||
Comment on attachment 8564476 [details] [diff] [review] patch Despite its almost certain lack of use I think we should be cautious, announce on the newsgroup and then put this under a pref and disable on nightly only as a first step.
Attachment #8564476 -
Flags: review+ → review-
Comment 5•8 years ago
|
||
Posted the site compatibility doc: https://www.fxsitecompat.com/en-US/docs/2015/getelementbyid-and-several-properties-will-be-removed-from-svgsvgelement/
Keywords: site-compat
Comment 6•6 years ago
|
||
Any update? These were removed from Chrome two years ago, we saw virtually zero usage and AFAIK heard no issues after removal. https://groups.google.com/a/chromium.org/d/msg/blink-dev/uJCmB7SzYNo/cBASMfJuBAAJ https://bugs.chromium.org/p/chromium/issues/detail?id=537177 This is one of a small number of APIs which are not in Chrome but in all other major browsers (a position we generally don't want to be in).
Comment 7•6 years ago
|
||
historical test for web-platform-tests: https://github.com/w3c/web-platform-tests/pull/6799
Updated•6 years ago
|
Attachment #8564476 -
Flags: review- → review+
Comment 8•5 years ago
|
||
The patch is r+ here, but did it actually land?
Comment 9•5 years ago
|
||
It did not.
Assignee | ||
Comment 11•5 years ago
|
||
No, I think I just missed the r+. I will send a dev-platform mail for completeness.
Comment 12•5 years ago
|
||
I think there are WPT changes that would be required now in order to land this. Ie. we will pass some tests that we currently fail.
Assignee | ||
Comment 13•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecb3866cb8d5a7c2d306c89d21a875533d4b56eb
Flags: needinfo?(cam)
Assignee | ||
Comment 14•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Comment 15•5 years ago
|
||
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e998b6b3f9b0 Remove SVGSVGElement.{pixel,screenPixel}UnitToMillimeter{X,Y}. r=longonsr,bz
Keywords: checkin-needed
Comment 16•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e998b6b3f9b0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment 17•5 years ago
|
||
Posted the compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/pixelunittomillimeterx-and-similar-properties-have-been-removed-from-svgsvgelement/
Comment 18•5 years ago
|
||
Mentioned removal here: https://developer.mozilla.org/en-US/Firefox/Releases/61#SVG_2 Compat data on https://developer.mozilla.org/en-US/docs/Web/API/SVGSVGElement#Browser_compatibility will be updated soon: https://github.com/mdn/browser-compat-data/pull/2014
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•