1133175 - remove SVGTests.hasExtension

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: patch

The SVG WG resolved to remove SVGTests.hasExtension due to lack of use and being a poor API.  (We'll likely discuss requiredExtensions="" later.)

r?longsonr for the removal, r?bz for the IDL change DOM peer review.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8564479 [details] [diff] [review]
patch

r=me on the IDL bit.

Comment 2

[Robert Longson [:longsonr]]

Comment on attachment 8564479 [details] [diff] [review]
patch

Announce on the newsgroup and then I think we should put this under a pref and disable on nightly only as a first step.

Comment 3

[Kohei Yoshino [:kohei]]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-US/docs/2015/getelementbyid-and-several-properties-will-be-removed-from-svgsvgelement/

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Robert Longson [:longsonr] from comment #2)

Comment on attachment 8564479 [details] [diff] [review]
patch

Announce on the newsgroup and then I think we should put this under a pref
and disable on nightly only as a first step.

Could you address or delegate?

Comment 5

[Robert Longson [:longsonr]]

So we should check what Chrome does. If it's removed there we should just announce it and remove it.

Comment 6

[Cameron McCormack (:heycam)]

Confirmed that Chrome does not currently implement hasExtension(). I will send a mail.

Comment 7

[Cameron McCormack (:heycam)]

It's still implemented in WebKit but I forsee no problem removing this.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ce2113ec692
Remove SVGTests.hasExtension. r=bz,longsonr

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3ce2113ec692

Comment 10

[Kohei Yoshino [:kohei]]

Posted site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2019/hasextension-has-been-removed-from-some-svg-interfaces/