Closed Bug 1133175 Opened 5 years ago Closed 5 months ago

remove SVGTests.hasExtension

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: heycam, Assigned: heycam)

Details

(Keywords: dev-doc-needed, site-compat)

Attachments

(1 file)

Attached patch patchSplinter Review
The SVG WG resolved to remove SVGTests.hasExtension due to lack of use and being a poor API.  (We'll likely discuss requiredExtensions="" later.)

r?longsonr for the removal, r?bz for the IDL change DOM peer review.
Attachment #8564479 - Flags: review?(longsonr)
Attachment #8564479 - Flags: review?(bzbarsky)
Comment on attachment 8564479 [details] [diff] [review]
patch

r=me on the IDL bit.
Attachment #8564479 - Flags: review?(bzbarsky) → review+
Comment on attachment 8564479 [details] [diff] [review]
patch

Announce on the newsgroup and then I think we should put this under a pref and disable on nightly only as a first step.
Attachment #8564479 - Flags: review?(longsonr) → review-

(In reply to Robert Longson [:longsonr] from comment #2)

Comment on attachment 8564479 [details] [diff] [review]
patch

Announce on the newsgroup and then I think we should put this under a pref
and disable on nightly only as a first step.

Could you address or delegate?

Flags: needinfo?(cam)

So we should check what Chrome does. If it's removed there we should just announce it and remove it.

Confirmed that Chrome does not currently implement hasExtension(). I will send a mail.

Flags: needinfo?(cam)

It's still implemented in WebKit but I forsee no problem removing this.

Attachment #8564479 - Flags: review- → review+
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ce2113ec692
Remove SVGTests.hasExtension. r=bz,longsonr
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.