Closed Bug 1133199 Opened 10 years ago Closed 7 years ago

Message encoding is not valid on Netsoul

Categories

(Instantbird Graveyard :: Conversation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: meyer.thibault, Unassigned)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/40.0.2214.111 Safari/537.36 Steps to reproduce: 1. Sending message with french spécial chars (ie: déjà-vu). 2. The recipient must use another client like bNetsoul (official), Samesoul, SoulMeBaby or AdiumSoul Actual results: The recipient receive the URL-encoded string "d%E9j%E0-vu" that not fit with "d%C3%A9j%C3%A0-vu". Expected results: The URL-encoded string "d%E9j%E0-vu" not fit with the expected result: "d%C3%A9j%C3%A0-vu".
I'm working on the refactoring of the file ns_utils.c to fix this issue and simplify the URL-encoding/decoding process. Is documentation exist to explain how to clone and compile "purple" ?
Thanks Aleth.
I can't compile. after a while, the compilation stop. #> hg clone http://hg.mozilla.org/comm-central #> cd comm-central #> python client.py checkout #> echo 'ac_add_options --enable-debug' > .mozconfig #> echo 'ac_add_options --enable-application=im' >> .mozconfig #> ./mozilla/mach build Everything is good and the application run very well, so I go to the next step (add the libpurple) #> hg clone http://hg.mozilla.org/users/florian_queze.net/purple mozilla/extensions/purple #> echo 'ac_add_options --enable-extensions=purple' >> .mozconfig #> ./mozilla/mach clobber #> ./mozilla/mach build 99:07.05 purpleProxyInfo.o 99:07.77 purpleSockets.o 99:09.50 purpleTimer.o 99:10.23 purpleTooltipInfo.o 99:10.77 make[5]: *** No rule to make target `../../../../extensions/purple/libpurple/libpurple.a', needed by `libpurplexpcom.so'. Stop. 99:10.78 make[4]: *** [../../../purplexpcom/src/libpurplexpcom.so] Error 2 99:10.78 make[3]: *** [extensions/purple/libpurple/protocols/sipe/target] Error 2 99:10.78 make[2]: *** [compile] Error 2 99:10.78 make[1]: *** [default] Error 2 99:10.78 make: *** [build] Error 2 99:10.84 252 compiler warnings present.
Attached patch patch.diffSplinter Review
I have patchd the encoding error and simplify the file by removing "home-made" url encoding functions. I have try a big refactoring of the netsoul lib from scratch, but I have an issue with Instantbird : they are no issues on compilation, account creation works, but when I click on "Connect", the button become disabled during 1 second and back to enabled state and the function "netsoul_login" was never called (i check, and this function is present in the PurpleProtocolInfo declaration... Is a know issue ?
(In reply to Thibault from comment #6) > I have try a big refactoring of the netsoul lib from scratch, but I have an > issue with Instantbird : they are no issues on compilation, account creation > works, but when I click on "Connect", the button become disabled during 1 > second and back to enabled state and the function "netsoul_login" was never > called (i check, and this function is present in the PurpleProtocolInfo > declaration... Is a know issue ? Doesn't seem familiar, no. For what is worth, if you want to rewrite the netsoul protocol plugin 'from scratch', I would strongly recommend implementing the new version in JavaScript.
(In reply to Florian Quèze [:florian] [:flo] from comment #7) > For what is worth, if you want to rewrite the netsoul protocol plugin 'from > scratch', I would strongly recommend implementing the new version in > JavaScript. Good idea, i will investigate on the protocol plugin creation in JS process. Thanks
(In reply to Thibault from comment #8) > (In reply to Florian Quèze [:florian] [:flo] from comment #7) > > For what is worth, if you want to rewrite the netsoul protocol plugin 'from > > scratch', I would strongly recommend implementing the new version in > > JavaScript. > > Good idea, i will investigate on the protocol plugin creation in JS process. > Thanks Asking us questions on IRC in #instantbird on irc.mozilla.org will likely save you a lot of time while researching this.
On the behalf of Florian: Closing bugs related to the Instantbird UI as WONTFIX, as the development of the standalone chat client Instantbird has stopped. Instantbird users are encouraged to migrate to Thunderbird. The user interface of instant messaging in Thunderbird will feel familiar, as the Thunderbird IM support started as a fork of Instantbird.
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: