1133245 - Add ID HTML parameters to <tr> table rows on show_bug.cgi

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Andre Klapper]

Allow using custom CSS to tweak how certain fields (both their label and their dropdown(s)) are displayed so customizations do not need to change templates anymore.

Comment 1

[Andre Klapper]

Attachment: Add ID HTML parameters to <tr> table rows on show_bug.cgi

Comment 2

[Olav Vitters]

Comment on attachment 8564587 [details] [diff] [review]
Add ID HTML parameters to <tr> table rows on show_bug.cgi

Review of attachment 8564587 [details] [diff] [review]:
-----------------------------------------------------------------

::: template/en/default/bug/edit.html.tmpl
@@ +928,4 @@
>      [% LAST IF show_bug_flags && show_more_flags && bug_flags_set %]
>    [% END %]
>    [% IF show_bug_flags %]
> +  <tr id="field_tablerow_flags">

You changed the indenting level here.

Comment 3

[Andre Klapper]

Attachment: 0001-Bug-1133245-Add-ID-parameters-to-tr-table-rows-on-sh.patch

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8567652 [details] [diff] [review]
0001-Bug-1133245-Add-ID-parameters-to-tr-table-rows-on-sh.patch

Review of attachment 8567652 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

Comment 5

[Frédéric Buclin]

Comment on attachment 8567652 [details] [diff] [review]
0001-Bug-1133245-Add-ID-parameters-to-tr-table-rows-on-sh.patch

>+    <tr id="field_tablerow_product">

why the field_ prefix?

Comment 6

[Andre Klapper]

(In reply to Frédéric Buclin from comment #5)
> why the field_ prefix?

Stuff inside already uses "field_label" and "field_value" so if you prefer a different prefix for those container IDs than the current field_tablerow_* prefixes, please share it.

Comment 7

[Frédéric Buclin]

Just no prefix at all.

Comment 8

[Andre Klapper]

(In reply to Frédéric Buclin from comment #7)
> Just no prefix at all.

Please provide reasons why that's better and if "prefix" refers to "field_" or to "field_tablerow_".

Comment 9

[Frédéric Buclin]

(In reply to Andre Klapper from comment #8)
> Please provide reasons why that's better and if "prefix" refers to "field_"
> or to "field_tablerow_".

Longer names are useless, unless they bring some useful information. I have no scientific reasoning on this. :)

Comment 10

[:glob ✱]

to keep consistency with the current somewhat verbose id scheme on show_bug, i'm happy to take the patch as-is.

Comment 11

[Andre Klapper]

Thanks. I don't have git push rights so anybody with access feel free to push the patch.

Comment 12

[David Lawrence [:dkl]]

Committed.

To ssh://[e-mail]/bugzilla/bugzilla.git
   88e4275..3223291  master -> master