1133246 - Buttons aren't aligned properly with content on about pages using info-pages.css

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Tim Nguyen :ntim]

The following code fixes the issue :

.button-container > button:first-child {
  -moz-margin-start: 0;
}

Comment 1

[Tim Nguyen :ntim]

The code mentioned earlier needs to be added to toolkit/themes/shared/in-content/info-pages.inc.css

Comment 2

[ANKIT JENA]

Hi,I'm new to open source and would like to work on it!How do I get started?
Thanks!

Comment 3

[Tim Nguyen :ntim]

(In reply to ANKIT JENA from comment #2)
> Hi,I'm new to open source and would like to work on it!How do I get started?
> Thanks!

Thanks for your interest !

You can get started by setting up your build environment, you can take a look at the documentation [0], or watch the video tutorials [1].
Once you've done so, generate a patch file that adds the code mentioned in comment #0 inside toolkit/themes/shared/in-content/info-pages.inc.css.
If you need help, you can join #introduction on IRC.

[0] : https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions
[1] : http://codefirefox.com

Comment 4

[Timur Valeev]

Attachment: buttons_aligned_v0.1.patch

Hi. I'm new in firefox development process. So I create the patch. Please check it.

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 8564914 [details] [diff] [review]
buttons_aligned_v0.1.patch

Review of attachment 8564914 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, looks good to me !

::: toolkit/themes/shared/in-content/info-pages.inc.css
@@ +85,5 @@
>  tree {
>    min-height: 12em;
>    margin-top: 1.2em;
>    width: 100%;
> +}

This blank line change isn't needed. Please restore the new line here.

Comment 6

[Timur Valeev]

Attachment: buttons_aligned_v0.2.patch

I created new patch that delete new line symbol in the end of css file. Is it right?

Comment 7

[Tim Nguyen :ntim]

Comment on attachment 8564936 [details] [diff] [review]
buttons_aligned_v0.2.patch

Review of attachment 8564936 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, thanks. Asking review from someone who has review powers.

Comment 8

[Tim Nguyen :ntim]

Your patch will be checked in, and once it lands on mozilla-central, it will appear on nightly the next day. :)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/9e8cbc322957

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9e8cbc322957