Closed Bug 1133246 Opened 5 years ago Closed 5 years ago

Buttons aren't aligned properly with content on about pages using info-pages.css

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 38
Tracking Status
firefox38 --- fixed

People

(Reporter: ntim, Assigned: tvaleev, Mentored)

References

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(1 file, 1 obsolete file)

The following code fixes the issue :

.button-container > button:first-child {
  -moz-margin-start: 0;
}
Mentor: ntim007
Whiteboard: [good first bug][lang=css]
The code mentioned earlier needs to be added to toolkit/themes/shared/in-content/info-pages.inc.css
Hi,I'm new to open source and would like to work on it!How do I get started?
Thanks!
(In reply to ANKIT JENA from comment #2)
> Hi,I'm new to open source and would like to work on it!How do I get started?
> Thanks!

Thanks for your interest !

You can get started by setting up your build environment, you can take a look at the documentation [0], or watch the video tutorials [1].
Once you've done so, generate a patch file that adds the code mentioned in comment #0 inside toolkit/themes/shared/in-content/info-pages.inc.css.
If you need help, you can join #introduction on IRC.

[0] : https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions
[1] : http://codefirefox.com
Attached patch buttons_aligned_v0.1.patch (obsolete) — Splinter Review
Hi. I'm new in firefox development process. So I create the patch. Please check it.
Comment on attachment 8564914 [details] [diff] [review]
buttons_aligned_v0.1.patch

Review of attachment 8564914 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, looks good to me !

::: toolkit/themes/shared/in-content/info-pages.inc.css
@@ +85,5 @@
>  tree {
>    min-height: 12em;
>    margin-top: 1.2em;
>    width: 100%;
> +}

This blank line change isn't needed. Please restore the new line here.
Assignee: nobody → tvaleev
Status: NEW → ASSIGNED
I created new patch that delete new line symbol in the end of css file. Is it right?
Attachment #8564914 - Attachment is obsolete: true
Comment on attachment 8564936 [details] [diff] [review]
buttons_aligned_v0.2.patch

Review of attachment 8564936 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, thanks. Asking review from someone who has review powers.
Attachment #8564936 - Flags: review?(jaws)
Attachment #8564936 - Flags: review?(jaws) → review+
Keywords: checkin-needed
Your patch will be checked in, and once it lands on mozilla-central, it will appear on nightly the next day. :)
https://hg.mozilla.org/integration/fx-team/rev/9e8cbc322957
Keywords: checkin-needed
Whiteboard: [good first bug][lang=css] → [good first bug][lang=css][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/9e8cbc322957
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=css][fixed-in-fx-team] → [good first bug][lang=css]
Target Milestone: --- → Firefox 38
You need to log in before you can comment on or make changes to this bug.