Closed
Bug 1133258
Opened 10 years ago
Closed 10 years ago
Add vibrancy to conversation nicklist
Categories
(Instantbird Graveyard :: Conversation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.6
People
(Reporter: Fallen, Assigned: Fallen)
Details
Attachments
(1 file, 2 obsolete files)
616 bytes,
patch
|
nhnt11
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
I've tested this with dom inspector, but I didn't actually do a build to see if the patch works. Please give it a quick test if you have a build :-)
Comment 2•10 years ago
|
||
Comment on attachment 8564616 [details] [diff] [review] Fix - v1 Review of attachment 8564616 [details] [diff] [review]: ----------------------------------------------------------------- ::: instantbird/themes/conversation.css @@ +311,4 @@ > } > > .conv-nicklist { > + -moz-appearance: -moz-mac-vibrancy-light; Shouldn't this be in a @media (-moz-mac-yosemite-theme) {..} block?
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to aleth [:aleth] from comment #2) > Shouldn't this be in a @media (-moz-mac-yosemite-theme) {..} block? I think its just a no-op on other macs. I don't see this used everywhere in c-c, so I think it should be good.
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8564616 -
Attachment is obsolete: true
Attachment #8564619 -
Flags: review?(nhnt11)
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8564619 -
Attachment is obsolete: true
Attachment #8564619 -
Flags: review?(nhnt11)
Attachment #8564625 -
Flags: review?(nhnt11)
Comment 6•10 years ago
|
||
Comment on attachment 8564625 [details] [diff] [review] Fix - v3 Review of attachment 8564625 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, thanks for this!
Attachment #8564625 -
Flags: review?(nhnt11) → review+
Updated•10 years ago
|
Keywords: checkin-needed
Comment 7•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/eda552c6aaa5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in
before you can comment on or make changes to this bug.
Description
•