1133258 - Add vibrancy to conversation nicklist

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

I've tested this with dom inspector, but I didn't actually do a build to see if the patch works. Please give it a quick test if you have a build :-)

Comment 2

[aleth [:aleth]]

Comment on attachment 8564616 [details] [diff] [review]
Fix - v1

Review of attachment 8564616 [details] [diff] [review]:
-----------------------------------------------------------------

::: instantbird/themes/conversation.css
@@ +311,4 @@
>  }
>  
>  .conv-nicklist {
> +  -moz-appearance: -moz-mac-vibrancy-light;

Shouldn't this be in a @media (-moz-mac-yosemite-theme) {..} block?

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

(In reply to aleth [:aleth] from comment #2)

> Shouldn't this be in a @media (-moz-mac-yosemite-theme) {..} block?

I think its just a no-op on other macs. I don't see this used everywhere in c-c, so I think it should be good.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v2

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v3

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8564625 [details] [diff] [review]
Fix - v3

Review of attachment 8564625 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks for this!

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

https://hg.mozilla.org/comm-central/rev/eda552c6aaa5