Closed Bug 1133284 Opened 5 years ago Closed 5 years ago

Remove nonstandard expression closures from services/sync

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

Expression closures (shorthand function syntax) are a nonstandard SpiderMonkey feature we would like to remove (in bug 1083459).
Attachment #8564661 - Flags: review?(mconnor)
OS: Mac OS X → All
Hardware: x86 → All
Attachment #8564661 - Flags: review?(mconnor) → review?(rnewman)
Comment on attachment 8564661 [details] [diff] [review]
exclo-services.patch

Review of attachment 8564661 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/common/tests/unit/head_helpers.js
@@ +63,5 @@
>   *        Any number of arguments to print out
>   * @usage _("Hello World") -> prints "Hello World"
>   * @usage _(1, 2, 3) -> prints "1 2 3"
>   */
> +let _ = function(some, debug, text, to) { print(Array.slice(arguments).join(" ")); };

Can we multi-line this and similar functions? If it has a brace, I'd prefer it on separate lines.
Attachment #8564661 - Flags: review?(rnewman) → review+
Thanks. I expanded the single-line functions with braces on separate lines, as you suggested.

https://hg.mozilla.org/integration/mozilla-inbound/rev/55f796c0f011
https://hg.mozilla.org/mozilla-central/rev/55f796c0f011
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.