1133284 - Remove nonstandard expression closures from services/sync

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: exclo-services.patch

Expression closures (shorthand function syntax) are a nonstandard SpiderMonkey feature we would like to remove (in bug 1083459).

Comment 1

[Richard Newman [:rnewman]]

Comment on attachment 8564661 [details] [diff] [review]
exclo-services.patch

Review of attachment 8564661 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/common/tests/unit/head_helpers.js
@@ +63,5 @@
>   *        Any number of arguments to print out
>   * @usage _("Hello World") -> prints "Hello World"
>   * @usage _(1, 2, 3) -> prints "1 2 3"
>   */
> +let _ = function(some, debug, text, to) { print(Array.slice(arguments).join(" ")); };

Can we multi-line this and similar functions? If it has a brace, I'd prefer it on separate lines.

Comment 2

[Chris Peterson [:cpeterson]]

Thanks. I expanded the single-line functions with braces on separate lines, as you suggested.

https://hg.mozilla.org/integration/mozilla-inbound/rev/55f796c0f011

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/55f796c0f011