Closed Bug 1133291 Opened 5 years ago Closed 5 years ago

Suppress -Wunused warnings in third-party code: openaes

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Platform:
x86
macOS
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38
Tracking Flags:
Tracking Status
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(2 files)

suppress-openaes-warnings.patch
1.00 KB, patch
cpearce
: review+
Details | Diff | Splinter Review
Beta patch
1.92 KB, patch
lmandel
: approval-mozilla-beta+
Details | Diff | Splinter Review 
Do we expect to import upstream openaes ever again? If not, then I can remove this unused code instead of suppressing the warnings. If yes, then bug 1092023's local changes to oaes_lib.c will be overwritten.

media/gmp-clearkey/0.1/openaes/oaes_lib.c:30:19: error: unused variable '_NR' [-Werror,-Wunused-const-variable]
media/gmp-clearkey/0.1/openaes/oaes_lib.c:289:17: error: unused function 'oaes_word_rot_right' [-Werror,-Wunused-function]
Attachment #8564673 - Flags: review?(cpearce)
Attachment #8564673 - Flags: review?(cpearce) → review+
Do you expect to import upstream openaes ever again? If not, then I can remove this unused code instead of suppressing the warnings. If yes, then bug 1092023's local changes to oaes_lib.c will be overwritten.
Flags: needinfo?(cpearce)
Doubt it. Edwin, comment 2?
Flags: needinfo?(cpearce) → needinfo?(edwin)
(In reply to Chris Pearce (:cpearce) from comment #3)
> Doubt it. Edwin, comment 2?

Yeah, may as well remove it.
Flags: needinfo?(edwin)
https://hg.mozilla.org/mozilla-central/rev/f57201a6482d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Attached patch Beta patch — — Splinter Review 
Patch for beta branch as part of EME platform uplift.
Comment on attachment 8572375 [details] [diff] [review]
Beta patch

Requesting retroactive approval for Beta landing as part of EME platform uplift.
Attachment #8572375 - Flags: approval-mozilla-beta?
Comment on attachment 8572375 [details] [diff] [review]
Beta patch

Approved for Beta as part of EME platform uplift.
Attachment #8572375 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.