1133294 - ScriptedIndirectProxyHandler.[[GetOwnProperty]] can return an incomplete descriptor

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

This is supposed to be impossible according to ES6 draft rev 32 6.1.7.3:

http://people.mozilla.org/~jorendorff/es6-draft.html#sec-invariants-of-the-essential-internal-methods

At some point we should enforce that with an assertion.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Object.getOwnPropertyDescriptor(obj, key) should always return either undefined or a complete property descriptor, even if obj is a proxy

Comment 2

[Eric Faust [:efaust]]

Comment on attachment 8564679 [details] [diff] [review]
Object.getOwnPropertyDescriptor(obj, key) should always return either undefined or a complete property descriptor, even if obj is a proxy

Review of attachment 8564679 [details] [diff] [review]:
-----------------------------------------------------------------

Yep.

Comment 3

[Jason Orendorff [:jorendorff]]

https://tbpl.mozilla.org/?tree=Try&rev=8492396647de

Comment 4

[Jason Orendorff [:jorendorff]]

https://tbpl.mozilla.org/?tree=Try&rev=0f374955a4c5

Comment 5

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/25b9c28d877e

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/25b9c28d877e