1133355 - The Properties button and context menuitem should be disabled when multiple cards are selected.

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Philip Chee]

Bug 132453 which fixed this for Thunderbird also contained untested changes to suite, which, as far as I can tell, never worked. This bug is a followup to Bug 132453 to port the remaining parts to SeaMonkey.

Comment 1

[Philip Chee]

Attachment: Patch V1 Proposed fix.

Since Neil reviewed Thunderbird Bug 132453 I thought it appropriate for Neil to review the followup.

Comment 2

[[e-mail]]

(In reply to Philip Chee from comment #0)
> Bug 132453 which fixed this for Thunderbird also contained untested changes
> to suite, which, as far as I can tell, never worked.

I don't think the changes were meant to fix the bug for SeaMonkey, they were just there to prevent SeaMonkey from breaking.

Comment 3

[[e-mail]]

Comment on attachment 8564771 [details] [diff] [review]
Patch V1 Proposed fix.

> function AbResultsPaneOnClick(event)
> {
>+  CommandUpdate_AddressBook();
...
>   <menupopup id="composeMail" onpopupshowing="CommandUpdate_AddressBook();">
These changes shouldn't be needed.

> function DirPaneSelectionChangeMenulist()
> {
>   if (abList && abList.selectedItem) {
>     if (gSearchInput.value && (gSearchInput.value != "")) 
>       onEnterInSearchBar();
>     else
>       ChangeDirectoryByURI(abList.value);
>   }
>+  CommandUpdate_AddressBook();
> }
Again, the caller of this function calls CommandUpdate_AddressBook already.

>-    <command id="cmd_properties" oncommand="goDoCommand('cmd_properties');"/>
>+    <command id="cmd_properties" oncommand="goDoCommand('cmd_properties');" disabled="true"/>
Why this change?

Comment 4

[Philip Chee]

Attachment: Patch v2 minimal fix.

Unneeded changes removed.

>>-    <command id="cmd_properties" oncommand="goDoCommand('cmd_properties');"/>
>>+    <command id="cmd_properties" oncommand="goDoCommand('cmd_properties');" disabled="true"/>
> Why this change?
I was following Thunderbird. As far as I can tell it doesn't do anything. Reverted.

Comment 5

[Ian Neal]

Comment on attachment 8567965 [details] [diff] [review]
Patch v2 minimal fix.

[Triage Comment]
a=me for c-a/c-b too

Comment 6

[Philip Chee]

http://hg.mozilla.org/comm-central/rev/e46f97877090

Comment 7

[Philip Chee]

(In reply to Philip Chee from comment #6)
> http://hg.mozilla.org/comm-central/rev/e46f97877090
http://hg.mozilla.org/releases/comm-aurora/rev/ca6a6ae13066
http://hg.mozilla.org/releases/comm-beta/rev/2548998cee42