1133375 - Transitions are not cancelled when the combined duration is <= 0s

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Brian Birtles (:birtles)]

Attachment: cancel.html

As described in bug 960465 comment 39, we don't appear to be following step 3.2 of the algorithm for starting transitions:

> Otherwise, if the combined duration is less than or equal to 0s,
> then implementations must cancel the running transition. 
> http://dev.w3.org/csswg/css-transitions/#starting

See attached test case.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

We should also check that the code for starting transitions is correct.

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee029fea0fbe

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dee455c9586d

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: Condition starting (or cancelling) CSS transitions on the combined duration, rather than delay and duration both being exactly 0

The two count mochitests fail without the patch (the value tests pass,
though they exist partly just to flush); all tests pass with the patch.

Comment 5

[Brian Birtles (:birtles)]

Comment on attachment 8566200 [details] [diff] [review]
Condition starting (or cancelling) CSS transitions on the combined duration, rather than delay and duration both being exactly 0

Review of attachment 8566200 [details] [diff] [review]:
-----------------------------------------------------------------

r=birtles with that comment corrected.

::: layout/style/test/test_transitions_dynamic_changes.html
@@ +67,5 @@
> +utils.advanceTimeAndRefresh(10);
> +is(endCount, 0, "should not have started transition when combined duration less than or equal to 0");
> +p.style.transitionDelay = "-2s";
> +p.style.textIndent = "0";
> +is(cs.textIndent, "0px", "value should now be 100px");

I think the assertion text here is incorrect.

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c7b08a1d83f0

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c7b08a1d83f0