Closed Bug 1133391 Opened 6 years ago Closed 6 years ago

Remove unused variables in TabParent::RecvDispatchAfterKeyboardEvent

Categories

(Core :: DOM: Events, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: shelly, Assigned: daoshengmu)

Details

Attachments

(1 file, 2 obsolete files)

Remove unused variables in TabParent::RecvDispatchAfterKeyboardEvent, or other places if any.

https://dxr.mozilla.org/mozilla-central/source/dom/ipc/TabParent.cpp?from=TabParent.cpp&case=true#1893
Assignee: nobody → dmu
Attached patch bug1133391.patch (obsolete) — Splinter Review
Comment on attachment 8568416 [details] [diff] [review]
bug1133391.patch

Review of attachment 8568416 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you, looks good!

Can you follow the rules of commit message here?
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities

And I think you probably need to create a hg patch.
Attached patch bug1133391.patch (obsolete) — Splinter Review
Attachment #8568416 - Attachment is obsolete: true
Attachment #8568954 - Flags: review?(bugs)
I have amended the commit message and make a hg-format patch. Please have a check.
Attachment #8568954 - Flags: review?(bugs) → review+
Attached patch bug1133391.patchSplinter Review
Sorry. I have a fix on the commit message style.
Attachment #8568954 - Attachment is obsolete: true
Attachment #8569571 - Flags: review?(bugs)
Attachment #8569571 - Flags: review?(bugs) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cf124d6f6602
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.