Closed
Bug 1133391
Opened 10 years ago
Closed 10 years ago
Remove unused variables in TabParent::RecvDispatchAfterKeyboardEvent
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: shelly, Assigned: daoshengmu)
Details
Attachments
(1 file, 2 obsolete files)
807 bytes,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Remove unused variables in TabParent::RecvDispatchAfterKeyboardEvent, or other places if any.
https://dxr.mozilla.org/mozilla-central/source/dom/ipc/TabParent.cpp?from=TabParent.cpp&case=true#1893
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → dmu
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Try server result:
https://tbpl.mozilla.org/?tree=Try&rev=ffce53f2d29c
Reporter | ||
Comment 3•10 years ago
|
||
Comment on attachment 8568416 [details] [diff] [review]
bug1133391.patch
Review of attachment 8568416 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you, looks good!
Can you follow the rules of commit message here?
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities
And I think you probably need to create a hg patch.
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8568416 -
Attachment is obsolete: true
Attachment #8568954 -
Flags: review?(bugs)
Assignee | ||
Comment 5•10 years ago
|
||
I have amended the commit message and make a hg-format patch. Please have a check.
Updated•10 years ago
|
Attachment #8568954 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Sorry. I have a fix on the commit message style.
Attachment #8568954 -
Attachment is obsolete: true
Attachment #8569571 -
Flags: review?(bugs)
Updated•10 years ago
|
Attachment #8569571 -
Flags: review?(bugs) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 8•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•