1133400 - [B2G][Emulator] Fix an implementation defect of emulator 'modem enable|disable <feature>'

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Description

[Ben Hsu [:HoPang]]

There are two things to be fixed. Firsr, we should check whether the argument is passed before we compare it with feature strings(e.g., "hold"). Second, if the passed argument doesn't match any feature strings, it would be nice to print an error message.

Comment 1

[Ben Hsu [:HoPang]]

Attachment: [external/qemu] pull request 131. r=echen

Comment 2

[Edgar Chen [:edgar]]

Comment on attachment 8564860 [details] [review]
[external/qemu] pull request 131. r=echen

I have left some comments in github, please address them and request review again, thank you.

Comment 3

[Ben Hsu [:HoPang]]

Comment on attachment 8564860 [details] [review]
[external/qemu] pull request 131. r=echen

Hi Edgar,

I've updated the pull request. Do you mind reviewing it again?

Comment 4

[Edgar Chen [:edgar]]

Comment on attachment 8564860 [details] [review]
[external/qemu] pull request 131. r=echen

Thank you.

Comment 5

[Ben Hsu [:HoPang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=29ccfc63ad2a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/platform_external_qemu/commit/3b3407510d6e2c60242e8b9b5f2bc1783ca0a0e4