1133417 - Failed tests in section W4 after enabling pointer events

Status: RESOLVED FIXED

(Firefox :: Untriaged, defect)

Description

[Maksim Lebedev]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141105223254

Steps to reproduce:

Tests on TRY servers. Section W 4


Actual results:

TEST-UNEXPECTED-PASS | /pointerevents/pointerevent_constructor.html | PointerEvent constructor - expected FAIL
TEST-UNEXPECTED-OK | /pointerevents/pointerevent_constructor.html | expected TIMEOUT
TEST-UNEXPECTED-PASS | /pointerevents/pointerevent_touch-action-illegal.html | 'pan-x none' is corrected properly - expected FAIL
TEST-UNEXPECTED-PASS | /pointerevents/pointerevent_touch-action-illegal.html | 'pan-y none' is corrected properly - expected FAIL
TEST-UNEXPECTED-PASS | /pointerevents/pointerevent_touch-action-illegal.html | 'auto none' is corrected properly - expected FAIL
TEST-UNEXPECTED-PASS | /pointerevents/pointerevent_touch-action-verification.html | 'auto' is set properly - expected FAIL
TEST-UNEXPECTED-PASS | /pointerevents/pointerevent_touch-action-verification.html | 'pan-x' is corrected properly - expected FAIL
TEST-UNEXPECTED-PASS | /pointerevents/pointerevent_touch-action-verification.html | 'pan-y' is set properly - expected FAIL
TEST-UNEXPECTED-PASS | /pointerevents/pointerevent_touch-action-verification.html | 'none' is set properly - expected FAIL
TEST-UNEXPECTED-PASS | /pointerevents/pointerevent_touch-action-verification.html | 'manipulation' is set properly - expected FAIL


Expected results:

Section W4 should be green without issues.

Comment 1

[Maksim Lebedev]

To resolve this issue we should change expectation of "web-platform-test" suite.
That expectations are situated in .\testing\web-platform\meta\pointerevents folder.

Comment 2

[Maksim Lebedev]

Attachment: w4_section_tests_ver1.diff

- Removed expected "FAIL" results.

Suggestions and comments and objections are very welcome.

Comment 3

[Maksim Lebedev]

Without patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=81769199ab34
With patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5dc88249a78a

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8610518 [details] [diff] [review]
w4_section_tests_ver1.diff

r+ (looks like wpt are run only on desktop)

Comment 5

[Maksim Lebedev]

If there are no objections, I will put checkin-needed flag...
...at the same time as bug 1166347 will be checkined too.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

So why are these failing? The `prefs: [dom.w3c_pointer_events.enabled:true]` line should make sure that the default pref change shouldn't affect them. Should we add layout.css.touch_action.enabled there?

Comment 7

[Maksim Lebedev]

(In reply to :Ms2ger from comment #6)
> So why are these failing? The `prefs: [dom.w3c_pointer_events.enabled:true]`
> line should make sure that the default pref change shouldn't affect them.
> Should we add layout.css.touch_action.enabled there?
I am not quite sure for that, but I can make some test for that.

Comment 8

[Maksim Lebedev]

Attachment: w4_section_tests_ver2.diff

+ Changed preference dependencies

Suggestions and comments and objections are very welcome.

Comment 9

[Maksim Lebedev]

Enabling PE: https://treeherder.mozilla.org/#/jobs?repo=try&revision=211ea2f613d7
PATCH: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d93c75d2ca41
Enabling PE + PATCH: https://treeherder.mozilla.org/#/jobs?repo=try&revision=14f32c25e9e5

Comment 10

[Maksim Lebedev]

...ups, incorrect link.
PATCH: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d93c75d2ca4

Comment 11

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8612854 [details] [diff] [review]
w4_section_tests_ver2.diff

Review of attachment 8612854 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 12

[Maksim Lebedev]

If there are no objections, I put checkin-needed flag.

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e4e4fc58ded1

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e4e4fc58ded1