1133424 - [Stingray] [Component] Create web component - smart-scrollbox

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[Sung Chiu[:sungchiu]]

1. Change XScrollable to web component named smart-scrollbox

Comment 1

[Sung Chiu[:sungchiu]]

Attachment: Pull Request

1. Create smart-scrollbox that is similar to scrollable but without dependencies on home card.
2. Use shadow DOM to create the template
3. Remove functions related to 'card'
4. Compared to scrollable, styles of DOM elements in smart-scrollbox is controlled by user instead of positioned by transform:translate.
5. If the node (not items) is current node, class 'active' will be added instead of 'focused' since it doesn't have real focus.

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8569629 [details] [review]
Pull Request

Please see my comments at PR. Thanks.

Comment 3

[Sung Chiu[:sungchiu]]

Commit: https://github.com/sean2449/gaia/commit/37bbf8786f625152de7144e917202febf6821612
Gaia Try (all green): https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=cf4862a856ae

Comment 4

[Sung Chiu[:sungchiu]]

Sorry...put the wrong commit above.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8569629 [details] [review]
Pull Request

The code logic is OK but I think we can make some improve on comments; and eliminate some old naming to improve readability.
Please see my comments.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8569629 [details] [review]
Pull Request

Looks good to me. Sorry for late reviewing.

Comment 7

[Sung Chiu[:sungchiu]]

Commit: https://github.com/smart-components/smart-scrollbox/commit/4c9605e9fb00e12c5f0c1ba6a2938e061fdf78f3