Closed
Bug 1133440
Opened 10 years ago
Closed 10 years ago
output directory of get_about_memory can't specifed
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pyang, Unassigned)
References
Details
Attachments
(1 file)
In B2G/tools/include/device_utils.py
function create_specific_output_dir(out_dir) didn't return out_dir
But in get_about_memory.py:get_dump
it expects a return value as its out_dir
|
Reporter | |
Comment 2•10 years ago
|
||
Attachment #8564920 -
Flags: feedback?(erahm)
|
|
Reporter | |
Updated•10 years ago
|
Depends on: MTBF-Memory
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8564920 [details] [review]
wip.patch
Great catch :pyang! r=me. Let me know if you need me to land the patch.
Flags: needinfo?(erahm)
Attachment #8564920 -
Flags: feedback?(erahm) → review+
|
|
Reporter | |
Comment 4•10 years ago
|
||
Yes, please land it. Should I set any flag?
|
|
||
Comment 5•10 years ago
|
||
Updated the commit message and landed: https://github.com/mozilla-b2g/B2G/commit/548a7409ac2be241a2b553e57756a8b6f8056ef5
Thanks for the fix!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•