1133478 - Playback of video never starts

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

http://media.junglecode.net/test/mse/

This video never start.

The cause for it is that the moof's atom contains in order:
tfhd
trun
tfdt

as the trun parsing relies on having found a tfdt first, ParseTrun fails.

We shouldn't rely of the atoms being in a specific order, instead we should delay parsing the trun until all depending atoms have been found.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Postpone parsing TRUN atom until we have all dependent atoms

Postpone parsing trun until we have all dependents.

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8564977 [details] [diff] [review]
Postpone parsing TRUN atom until we have all dependent atoms

Review of attachment 8564977 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/binding/MoofParser.cpp
@@ +304,5 @@
>          tfdt = Tfdt(box);
> +        if (trun.IsAvailable()) {
> +          // We have a pending trun atom, process it now.
> +          ParseTrun(trun, tfhd, tfdt, aMdhd, aEdts);
> +        }

Suggestioin: It may make for simpler code to iterate twice over the boxes and look for the tfdt the first iteration. That would make it less stateful and probably easier to follow.

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Postpone parsing TRUN atom until we have all dependent atoms

like so?

Comment 4

[Jean-Yves Avenard [:jya]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9bb4736948d2

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9bb4736948d2

Comment 6

[Ralph Giles (:rillian)]

This isn't critical for youtube, so we don't need to uplift to 37 unless it becomes a dependency of a later change.