Closed Bug 1133481 Opened 11 years ago Closed 11 years ago

Intermittent browser_webconsole_bug_597136_network_requests_from_chrome.js | no exception was thrown when sending a network request from a chrome window -

Categories

(DevTools :: General, defect)

x86
Windows 8
defect
Not set
normal

Tracking

(firefox36 unaffected, firefox37 unaffected, firefox38 fixed, firefox-esr31 unaffected)

RESOLVED FIXED
Firefox 38
Tracking Status
firefox36 --- unaffected
firefox37 --- unaffected
firefox38 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: cbook, Assigned: sjakthol)

References

()

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Windows 8 64-bit fx-team debug test mochitest-devtools-chrome-3 https://treeherder.mozilla.org/logviewer.html#?job_id=2003055&repo=fx-team 03:19:07 INFO - 585 INFO TEST-UNEXPECTED-FAIL | browser/devtools/webconsole/test/browser_webconsole_bug_597136_network_requests_from_chrome.js | no exception was thrown when sending a network request from a chrome window -
Sami, is this possibly related to one of the other webconsole tests you fixed recently?
Flags: needinfo?(sjakthol)
Not related but easy to fix anyways. The test fails if a script error from browser code is delivered to the console service during the test. The logs for multiple above failures show that following error message is printed during the test: > Console message: [JavaScript Error: "couldn't look up addon: fx-devtools" {file: "jar:file:///C:/slave/test/build/application/firefox/browser/omni.ja!/components/nsBrowserGlue.js" line: 569}] The message is from an addon performance monitoring code that detects devtools taking a lot of CPU time (or whatever it's measuring). This patch makes the test to fail if the sourceFile of the error contains string "webconsole" as I think that was the original purpose of this test. This will match errors coming from browser/devtools/webconsole/*, toolkit/devtools/webconsole/* and toolkit/devtools/server/actors/webconsole.js but not any random error chrome code spews out while that test is running. Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=79bf222dfafe
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Flags: needinfo?(sjakthol)
Attachment #8566407 - Flags: review?(past)
Comment on attachment 8566407 [details] [diff] [review] webconsole-failure.patch Review of attachment 8566407 [details] [diff] [review]: ----------------------------------------------------------------- Sami, you rock!
Attachment #8566407 - Flags: review?(past) → review+
Keywords: checkin-needed
Ah yeah, that makes perfect sense. Bug 1071880 was backed out for now, but it's good that the test is already fixed for when it re-lands eventually.
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: