Closed Bug 1133483 Opened 5 years ago Closed 3 years ago

Intermittent resource-selection-invoke-audio-constructor.html | invoking resource selection with new Audio(src) - expected FAIL

Categories

(Core :: Audio/Video: Playback, defect, P5)

x86
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox51 --- wontfix
firefox52 --- wontfix
firefox53 --- fixed

People

(Reporter: cbook, Assigned: ctai)

References

()

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

Ubuntu VM 12.04 mozilla-inbound opt test web-platform-tests-2


https://treeherder.mozilla.org/logviewer.html#?job_id=6644567&repo=mozilla-inbound

02:36:00 INFO - TEST-UNEXPECTED-PASS | /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-audio-constructor.html | invoking resource selection with new Audio(src) - expected FAIL
[Mass Closure] Closing bug as the WORKSFORME as the intermittent failure has not been seen for 45+ days If this has been closed and you feel that it should Not have been closed, please reopen and add [leave open] to the whiteboard.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Component: Audio/Video → Audio/Video: Playback
Comment on attachment 8814766 [details]
Bug 1133483 - Dispatch |NoSupportedMediaSourceError| to main thread in |SelectResource|.

https://reviewboard.mozilla.org/r/95862/#review95830

::: dom/html/HTMLMediaElement.cpp:1216
(Diff revision 1)
>      } else {
>        const char16_t* params[] = { src.get() };
>        ReportLoadError("MediaLoadInvalidURI", params, ArrayLength(params));
>      }
> -    NoSupportedMediaSourceError();
> +    nsCOMPtr<nsIRunnable> event =
> +      NewRunnableMethod<const nsACString&>(this, &HTMLMediaElement::NoSupportedMediaSourceError, nsCString());

Use NewRunnableMethod<nsCString>(...) instead.

Also add a comment to match the code to the spec.
Attachment #8814766 - Flags: review?(jwwang) → review+
Comment on attachment 8814767 [details]
Bug 1133483 - Enable resource-selection-invoke-audio-constructor.html. .

https://reviewboard.mozilla.org/r/95864/#review95832
Attachment #8814767 - Flags: review?(jwwang) → review+
Please ensure that the review flags are properly set in MozReview so that Autoland can push this.
Assignee: nobody → ctai
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b47698f7703
Dispatch |NoSupportedMediaSourceError| to main thread in |SelectResource|. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/9f8294cdd9bb
Enable resource-selection-invoke-audio-constructor.html. r=jwwang.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3b47698f7703
https://hg.mozilla.org/mozilla-central/rev/9f8294cdd9bb
Status: REOPENED → RESOLVED
Closed: 4 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Please request Aurora/Beta approval on this when you get a chance.
Flags: needinfo?(ctai)
JW, do you think this bug need to uplift to Aurora/Beta?
Or just ride the train.
Flags: needinfo?(ctai) → needinfo?(jwwang)
It is worth uplifting if the change is low risk. However, since this only affects some test cases, I would prefer to let it ride the train.
Flags: needinfo?(jwwang)
OK, thanks.
You need to log in before you can comment on or make changes to this bug.