1133483 - Intermittent resource-selection-invoke-audio-constructor.html | invoking resource selection with new Audio(src) - expected FAIL

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P5)

Description

[Carsten Book [:Tomcat]]

Ubuntu VM 12.04 mozilla-inbound opt test web-platform-tests-2


https://treeherder.mozilla.org/logviewer.html#?job_id=6644567&repo=mozilla-inbound

02:36:00 INFO - TEST-UNEXPECTED-PASS | /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-audio-constructor.html | invoking resource selection with new Audio(src) - expected FAIL

Comment 1

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=6644567
repository: mozilla-inbound
start_time: 2015-02-16T02:08:28
who: tomcat[at]mozilla[dot]com
machine: tst-linux32-spot-078
buildname: Ubuntu VM 12.04 mozilla-inbound opt test web-platform-tests-2
revision: 15dea2b0929b

TEST-UNEXPECTED-PASS | /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-audio-constructor.html | invoking resource selection with new Audio(src) - expected FAIL
Return code: 1

Comment 2

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=b2g-inbound&job_id=1490218
repository: b2g-inbound
start_time: 2015-03-10T15:48:36
who: wkocher[at]mozilla[dot]com
machine: tst-linux32-spot-361
buildname: Ubuntu VM 12.04 b2g-inbound pgo test web-platform-tests-2
revision: c8db8c1478bc

TEST-UNEXPECTED-PASS | /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-audio-constructor.html | invoking resource selection with new Audio(src) - expected FAIL
Return code: 1

Comment 3

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=1161647
repository: mozilla-central
start_time: 2015-03-13T06:59:39
who: philringnalda[at]gmail[dot]com
machine: tst-linux32-spot-002
buildname: Ubuntu VM 12.04 mozilla-central pgo test web-platform-tests-2
revision: 2b1d903e7266

TEST-UNEXPECTED-PASS | /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-audio-constructor.html | invoking resource selection with new Audio(src) - expected FAIL
Return code: 1

Comment 4

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=7851703
repository: mozilla-inbound
start_time: 2015-03-20T09:01:25
who: rvandermeulen[at]mozilla[dot]com
machine: t-yosemite-r5-0045
buildname: Rev5 MacOSX Yosemite 10.10 mozilla-inbound opt test web-platform-tests-2
revision: bd0060c41a3d

TEST-UNEXPECTED-PASS | /html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-audio-constructor.html | invoking resource selection with new Audio(src) - expected FAIL
Return code: 1

Comment 5

[David Burns :automatedtester]

[Mass Closure] Closing bug as the WORKSFORME as the intermittent failure has not been seen for 45+ days If this has been closed and you feel that it should Not have been closed, please reopen and add [leave open] to the whiteboard.

Comment 6

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Bug 1133483 - Dispatch |NoSupportedMediaSourceError| to main thread in |SelectResource|.

We need to end the synchronous section when the src attribute is empty and then run the "failed with elements step" in non-sync section.

Review commit: https://reviewboard.mozilla.org/r/95862/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95862/

Comment 7

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: Bug 1133483 - Enable resource-selection-invoke-audio-constructor.html. .

Review commit: https://reviewboard.mozilla.org/r/95864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95864/

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8814766 [details]
Bug 1133483 - Dispatch |NoSupportedMediaSourceError| to main thread in |SelectResource|.

https://reviewboard.mozilla.org/r/95862/#review95830

::: dom/html/HTMLMediaElement.cpp:1216
(Diff revision 1)
>      } else {
>        const char16_t* params[] = { src.get() };
>        ReportLoadError("MediaLoadInvalidURI", params, ArrayLength(params));
>      }
> -    NoSupportedMediaSourceError();
> +    nsCOMPtr<nsIRunnable> event =
> +      NewRunnableMethod<const nsACString&>(this, &HTMLMediaElement::NoSupportedMediaSourceError, nsCString());

Use NewRunnableMethod<nsCString>(...) instead.

Also add a comment to match the code to the spec.

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8814767 [details]
Bug 1133483 - Enable resource-selection-invoke-audio-constructor.html. .

https://reviewboard.mozilla.org/r/95864/#review95832

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please ensure that the review flags are properly set in MozReview so that Autoland can push this.

Comment 11

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 8814766 [details]
Bug 1133483 - Dispatch |NoSupportedMediaSourceError| to main thread in |SelectResource|.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/95862/diff/1-2/

Comment 12

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 8814767 [details]
Bug 1133483 - Enable resource-selection-invoke-audio-constructor.html. .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/95864/diff/1-2/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b47698f7703
Dispatch |NoSupportedMediaSourceError| to main thread in |SelectResource|. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/9f8294cdd9bb
Enable resource-selection-invoke-audio-constructor.html. r=jwwang.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b47698f7703
https://hg.mozilla.org/mozilla-central/rev/9f8294cdd9bb

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Please request Aurora/Beta approval on this when you get a chance.

Comment 16

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

JW, do you think this bug need to uplift to Aurora/Beta?
Or just ride the train.

Comment 17

[JW Wang [:jwwang] [:jw_wang]]

It is worth uplifting if the change is low risk. However, since this only affects some test cases, I would prefer to let it ride the train.

Comment 18

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

OK, thanks.