1133581 - "childrenNode is null" error when creating new account from Account central and skipping Account provisioner

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, defect)

Description

[:aceman]

STR:
1. on Account central, click 'Create a new account', Email.
2. in Account provisioner, click 'Skip this'.

Error is shown in console.

Timestamp: 16.02.2015 22:09:20
Error: TypeError: childrenNode is null
Source File: chrome://messenger/content/AccountManager.js
Line: 165

Comment 1

[:aceman]

Attachment: patch

I traced it to msgNewMailAccount where we call selectServer(). For some reason it thinks there is an account manager, while there is not (only the account creation wizard). This seems to only happen when opened from the Account central, not from other means (e.g. File menu).

So I make it to really check if Account manager window is open. But I also think that call is useless while the Account wizard isn't modal (temporarily). The call is run immediately after opening the wizard so there is no account yet.

Comment 2

[Ian Neal]

How does modal ever become true?

Comment 3

[Ian Neal]

(In reply to Ian Neal from comment #2)
> How does modal ever become true?

Sorry that was the wrong question, it was meant to be "When modal becomes true, does it do the right thing?"

Comment 4

[:aceman]

I hope so, but even if not, I hope the added code makes the coder changing to modal think about it better.

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 8565155 [details] [diff] [review]
patch

Review of attachment 8565155 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think I like the modal part of this.

::: mailnews/base/prefs/content/accountUtils.js
@@ +445,3 @@
>      window.openDialog("chrome://messenger/content/accountcreation/emailWizard.xul",
> +                      "AccountSetup", "chrome,titlebar,centerscreen" +
> +                      (modal ? "modal" : ""),

missing comma, not that it matter since modal you always have modal false

Comment 6

[:aceman]

So what do you propose? Should I have unconditional return without the hints for future coders? :)

Comment 7

[Magnus Melin [:mkmelin]]

Not sure what a proper fix would be. Just a comment and return (if necessary) would be better than the variable.

Comment 8

[:aceman]

Attachment: patch v2

OK, no problem.

Comment 9

[:aceman]

Thanks.

Comment 10

[Kent James (:rkent)]

Eliminating spurious errors is something we need to do to clean up for release.

Comment 11

[Kent James (:rkent)]

Comment on attachment 8565711 [details] [diff] [review]
patch v2

Pushed https://hg.mozilla.org/comm-central/rev/afdb81ec2f4a

We'll look to uplift to aurora after nightly cycle.

Comment 12

[Kent James (:rkent)]

https://hg.mozilla.org/releases/comm-aurora/rev/1a31d788c726