1133583 - EME error notifications should pass the window to which they apply

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[:Gijs (he/him)]

Obviously I should have just noticed this in the review for bug 1111160. Sorry.

On the upside, I have a patch!

Comment 1

[:Gijs (he/him)]

Attachment: pass window in EME notifications instead of null subject,

This seems to work in my local testing. Does this look right?

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8565149 [details] [diff] [review]
pass window in EME notifications instead of null subject,

Review of attachment 8565149 [details] [diff] [review]:
-----------------------------------------------------------------

I trust that passing a window reference across process boundaries will somehow magically work with e10s enabled?

Comment 3

[:Gijs (he/him)]

(In reply to Chris Pearce (:cpearce) from comment #2)
> Comment on attachment 8565149 [details] [diff] [review]
> pass window in EME notifications instead of null subject,
> 
> Review of attachment 8565149 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I trust that passing a window reference across process boundaries will
> somehow magically work with e10s enabled?

No, the observer service doesn't do anything cross-window boundaries, AIUI (ie the notification will only fire in the same process as where notifyObservers is called, being the content process in our case). The browser code takes care of lobbing the required info across to the parent process based on the message manager for the relevant window - it already does this. :-)

Comment 4

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/5b4a18aeb511

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5b4a18aeb511

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/448ff154c5fd

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Beta patch

Patch for beta branch as part of EME platform uplift.

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8572376 [details] [diff] [review]
Beta patch

Requesting retroactive approval for Beta landing as part of EME platform uplift.

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8572376 [details] [diff] [review]
Beta patch

Approved for Beta as part of EME platform uplift.