113366 - Reduce biff notifications, move biff state into incoming server

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[David :Bienvenu]

We're telling rdf that things have changed in the folder pane when they haven't,
which causes us to paint more than we should. We were also storing biff state in
each individual folder, instead of the incoming server, where it belongs. So,
I've moved that stuff into the incoming server, and the biff methods on the
folder delegate to the server. Patch upcoming.

Comment 1

[David :Bienvenu]

Attachment: reduce biff change notifications, move biff into the server

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 60265 [details] [diff] [review]
reduce biff change notifications, move biff into the server

sr=sspitzer

Comment 3

[Navin Gupta]

I don't know much about biff, isn't biff just for new messages that come to 
inbox, then why move it to the server. Can you explain more?

PRPackedBool has to have some alignment issues taken care of? do you know
more about it. i thought like it will save space, 1byte instead of 4 bytes
when alignment is right?

Comment 4

[David :Bienvenu]

biff is only displayed on the server level - that's why I moved it to the
server. hasNewmessages is what you're thinking of as far as the inbox is concerned.

correct, if you put PRPackedBools next to each other, as I did, they'll each
take up a byte, instead of taking up four bytes each.

Comment 5

[Navin Gupta]

Comment on attachment 60265 [details] [diff] [review]
reduce biff change notifications, move biff into the server

r=naving

Comment 6

[David :Bienvenu]

fix checked in, hard to verify other than looking at the code.

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED via code inspection (LXR).  Any additional bugs about biff's
behavior should be logged separately.