1133713 - Remove installed addons from engineering builds

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1133713_remove_dev_apps_addons > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8565397 [details] [review]
[gaia] KevinGrandon:bug_1133713_remove_dev_apps_addons > mozilla-b2g:master

Arhtur - could you review or re-assign this? Just trying to clean up our dev_apps folder list.

Thanks!

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Hi Kevin, may I know the background of removing dev_apps? The fake addons installed for engineering builds allow us to play with the addon panel during development and it might still be helpful.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8565397 [details] [review]
[gaia] KevinGrandon:bug_1133713_remove_dev_apps_addons > mozilla-b2g:master

Flagging Rudy for the change regarding IME tests.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8565397 [details] [review]
[gaia] KevinGrandon:bug_1133713_remove_dev_apps_addons > mozilla-b2g:master

r=me for the IME testing part.
Thank you.

Comment 6

[Kevin Grandon :kgrandon]

Arthur - we are currently looking at ways to reduce engineering debt, and one item of concern was the crazy growing of the dev_apps folder. Our goal was to clean that up and have an easy way for developers to include apps in their devices when necessary. The main goal is to move dev_apps into fixtures/ folders so they can be easily included by marionette tests. Assuming that the main use-case of the apps is for testing, we should be writing marionette tests against them.

The idea was that if a developer does need them in their build, they can easily symlink it to the outoftree_apps/ folder, and it will always be flashed to the device. To do this, you would do something like:

mkdir outoftree_apps
cd outoftree_apps
ln -s ../apps/settings/test/fixtures/addon1 addon1

Does this sound like an acceptable solution? This still needs to be documented/communicated, and I will be working on that soon.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Got it, thanks for the clarification!

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8565397 [details] [review]
[gaia] KevinGrandon:bug_1133713_remove_dev_apps_addons > mozilla-b2g:master

The patch is looking good. r=me.

Comment 9

[Kevin Grandon :kgrandon]

I've just changed the PR to continue to include the addons, but to do so from the fixtures folder. I'm fine with doing this as it's a smaller change than the original PR, and they don't show up on the home screen. We can always remove them at a later date if we get some default addons installed into the OS.

Comment 10

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/cd958418940b66a58633a7d8a06bebecf544b53f