Fix ipdl code for bridged protocols that are also opened

RESOLVED FIXED in Firefox 39

Status

()

Core
IPC
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: peterv, Assigned: peterv)

Tracking

Trunk
mozilla39
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Currently we generate two identical Alloc* functions in the same actor.
(Assignee)

Comment 1

3 years ago
Created attachment 8565437 [details] [diff] [review]
v1
Attachment #8565437 - Flags: review?(wmccloskey)
Comment on attachment 8565437 [details] [diff] [review]
v1

Review of attachment 8565437 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/ipdl/test/cxx/TestBridgeMain.h
@@ +77,5 @@
> +                                 ProcessId otherProcess) MOZ_OVERRIDE
> +    {
> +        // This shouldn't be called. It's just a byproduct of testing that
> +        // the right code is generated for a bridged protocol that's also
> +        // opened, but we only test briding here.

briding -> bridging
Attachment #8565437 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ef647d61d1f
https://hg.mozilla.org/mozilla-central/rev/4ef647d61d1f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.