1133753 - Convert Mozmill about-window.js library to Python/Marionette

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect, P1)

Description

[Bob Silverberg [:bsilverberg]]

To support the update tests, we need to convert the following library:

http://hg.mozilla.org/qa/mozmill-tests/file/e16ab8d3d62d/firefox/lib/ui/about-window.js

Comment 1

[Bob Silverberg [:bsilverberg]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ui-tests/pull/107

This PR includes the commits for SoftwareUpdate as well, as AboutWindow depends on SoftwareUpdate, so you may want to wait to review this. Alternatively, you could just review the single commit in the PR that includes all the AboutWindow changes.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8569973 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ui-tests/pull/107

This looks great. The one big thing it misses is the usage of a separate class for the deck, so we have the correct abstraction similar to the pageinfo window.

Comment 3

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8569973 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ui-tests/pull/107

This is ready for another review

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8569973 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ui-tests/pull/107

I added my comments to the PR. We still have a bit to do here.

Comment 5

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8569973 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ui-tests/pull/107

This is ready for another review. As discussed today is my last day for a week, so you might need to finish this up for me.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8569973 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ui-tests/pull/107

r- mostly because of the button elemnet usage which seems to not work because those are not existent. Please check all my comments on the PR.

Comment 7

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8569973 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ui-tests/pull/107

This is ready for another review. As I noted on the diff, the wait_for_download_finished doesn't seem to be working when I test it manually. As I am now disappearing for a week, I assume you will take this over. I hope what I've done thus far is a good start.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8569973 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ui-tests/pull/107

This looks way better! But I have to r- because its still broken due to the usage of `Cu` and `Ci` in prefs.py. I will fix that and some nits in my follow-up PR.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: github_pull_request.txt

PR 121 replaces PR 107 from Bob with some additional fixes. Tests via Travis are passing now.

Comment 10

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8574622 [details] [review]
github_pull_request.txt

Looks good. Some style comments in github, no blockers though.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://github.com/mozilla/firefox-ui-tests/commit/16f5d24232ceff687c6c36f1eadc4fbcfbd6e0ab