1133862 - Remove MSE debug User Agent string

Status: VERIFIED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Ralph Giles (:rillian)]

Bug 1127448 added a build id to the user agent string when visiting youtube with MSE enabled to facilitate comparing failure logs. This must be removed once MSE is stable and shipping.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Disable everywhere.

Bug 1127448 makes this fail on desktop too. I propose we just disable the test there. That change should be temporary while 37 and maybe 38 are in beta, and we want it for testing a high-priority feature.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8565736 [details] [diff] [review]
Disable everywhere.

Not sure who the right person to rubberstamp this is, but I'm pretty sure it ain't me.

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8565736 [details] [diff] [review]
Disable everywhere.

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #2)

> Not sure who the right person to rubberstamp this is, but I'm pretty sure it
> ain't me.

:P

Trying module owner. Patrick, inbound didn't explode here, so maybe this is optional, but I fear we'll need it on 37.

Comment 4

[Patrick McManus [:mcmanus]]

content of UA strings isn't me - its usually :gerv fwiw

but I'm happy to rs the testing change for the moment.

Comment 5

[Patrick McManus [:mcmanus]]

Comment on attachment 8565736 [details] [diff] [review]
Disable everywhere.

Review of attachment 8565736 [details] [diff] [review]:
-----------------------------------------------------------------

rs=mcmanus

Comment 6

[Ralph Giles (:rillian)]

Thanks, this bug is just about the test issue.

Ryan, I suggest we land this on 37 only unless central starts failing.

Comment 7

[Ralph Giles (:rillian)]

Sorry, this patch should have been attached to bug 1111137.

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Ralph - This override needs to be removed in Beta 7 (gtb tomorrow). Can you please request uplift and coordinate this change with YouTube?

ni Sheila to add this to the MSE list if it's not already on it.

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Ralph is away. Transferring ni to cpearce.

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

I need a fix for this bug for Beta 7 today. I expected to have one this morning.

ni Anthony, Jet, Chris for help getting this cleaned up today.

Comment 11

[Chris Peterson [:cpeterson]]

The YouTube user agent override is #ifdef'd only for MOZ_UPDATE_CHANNEL != release, so the user agent override should not 'leak' into the release channel. Still, we will should back it out so the final Beta 37 build has the same configuration as the release channel.

https://mxr.mozilla.org/mozilla-central/source/browser/components/nsBrowserGlue.js#126

Comment 12

[Chris Pearce [:cpearce (Not reading bugmail)]]

I agree with cpeterson. The MSE debug info in the UA string is should not leak into release.

I can still prepare a backout for all branches if that's what people want.

Comment 13

[Chris Pearce [:cpearce (Not reading bugmail)]]

Discussed with lmandel on IRC. We'll wontfix this for 37, since the code should not be compiled/defined in a release channel build.

We should backout Bug 1133862 from aurora and central, assuming it's of no value there.

Comment 14

[:Gavin Sharp [email: [e-mail]]]

Let's call this fixed instead so that we can verify...

Comment 15

[Ralph Giles (:rillian)]

Stealing. We should start turning this off now that we've rolled out to release.

Comment 16

[Ralph Giles (:rillian)]

Attachment: Remove MSE debug user agent

Comment 17

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8587066 [details] [diff] [review]
Remove MSE debug user agent

Review of attachment 8587066 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 18

[Ralph Giles (:rillian)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d6d69f0f499

Comment 19

[Ralph Giles (:rillian)]

Oops, not fixed until it lands on m-c.

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4d6d69f0f499

Comment 21

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Does anything need manual testing here?

Comment 22

[Ralph Giles (:rillian)]

(In reply to Florin Mezei, QA (:FlorinMezei) from comment #21)
> Does anything need manual testing here?

It's worth verifying. Visit youtube and confirm we send the same User Agent to youtube and non-youtube domains, e.g. by looking at the request headers in the network tab of the developer tools.

Comment 23

[Ralph Giles (:rillian)]

Comment on attachment 8587066 [details] [diff] [review]
Remove MSE debug user agent

Approval Request Comment
[Feature/regressing bug #]: Bug 1127448/MSE
[User impact if declined]: Build ids shared with google when visiting youtube with non-release builds, reducing privacy.
[Describe test coverage new/current, TreeHerder]: Landed on m-c.
[Risks and why]: Risk is low. This patch just reverts the testing code and restores normal behaviour.
[String/UUID change made/needed]: None.

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/28e3d5964195

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f9441895096d

Comment 26

[Ada [:adalucinet]]

Verified as fixed with Firefox 38 beta 6 (BuildID: 20150420134330) and Nightly 40.0a1 (2015-04-22), under OSX 10.9.5, Windows 7 64 bit and Linux 14.04 32 bit - the same User Agent is sent to youtube and non-youtube domains, the Build ID is no longer displayed.

Comment 27

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

I think verification on 40 Nightly and 38 Beta should suffice here.