1133870 - LogSliceView raises ResourceNotFoundException (and thus 404s) for all exceptions

Status: RESOLVED FIXED

(Tree Management :: Treeherder: API, defect, P1)

Description

[Ed Morley [:emorley]]

Found during bug 1133837.

We were hitting permissions problems ([Errno 13] Permission denied: '/data/www/treeherder.mozilla.org/treeherder-service/treeherder/webapp/log_cache/tmpyTjP_n') & then "can't pickle BytesIO objects", but both of these exceptions were caught by the generic:

https://github.com/mozilla/treeherder-service/blob/f5c0b53e0ce6b527c5eb2d861adeb72e1e5859ea/treeherder/webapp/api/logslice.py#L81
            except Exception as e:
                logging.error(e)
                raise ResourceNotFoundException("log file not found")

Which gets converted to a 404 and no exception in new relic.

We should let the original exception bubble up in most cases.

Comment 1

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/9e43629ed9211bc530e91fa239652069c9c9e4ce
Bug 1133870 - Raise real exception and let it bubble up so real error is not hidden