Closed Bug 1133918 Opened 6 years ago Closed 6 years ago

Use SDWebImage for list image loading

Categories

(Firefox for iOS :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: wesj, Unassigned)

References

Details

Attachments

(1 file)

47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review
There's a lot of jank in the history list right now. We should use something to async load the images. SDWebImage seems nice (and handles the disk caching for us, yay!)
Attached file Pull request
Patch
Attachment #8565583 - Flags: review?(bnicholson)
Attachment #8565583 - Flags: review?(sarentz)
Comment on attachment 8565583 [details] [review]
Pull request

r=me with comments fixed.
Attachment #8565583 - Flags: review?(bnicholson) → review+
Blocks: iosfavicons
Landed
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.