113401 - remove obsolete chrome rules from Makefiles

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P4)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm told that after warren landed jarring, not all the old rules were removed
from the makefiles.  These remaining rules from the makefiles make it very
confusing to figure out what needs to be done to add chrome files -- or figure
out what went wrong when the tree is broken because somebody did it wrong.

It's been suggested to me that all of these are obsolete (and even builds
without JAR packaging use the jar.mn), but I'm not really sure:

http://lxr.mozilla.org/seamonkey/search?string=CHROME_CONTENT
http://lxr.mozilla.org/seamonkey/search?string=CHROME_DIR (excl. "$chrome_dir")

There are probably also some makefiles in directories that we don't descend into
and makefiles that we don't need to descend into that could be cleaned up,
although perhaps that should be a separate bug.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(I might even be willing to help do this if somebody assures me what's safe and
what isn't...)

Comment 2

[hacker formerly known as [e-mail]]

Bryner did some cleanup on the unix side a while ago.  IIRC, all CHROME_*
variables can be purged. They are definitely not used in the unix side.  On
win32, the old MOZ_OLD_JAR_PACKAGING ifdefs in rules.mak will need to be removed
before the aforementioned variables can be purged.

Comment 3

[hacker formerly known as [e-mail]]

nmake is dead. long live gmake.

Comment 4

[Jon Granrose]

and so it begins.

verified wontfix.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Hold on a sec.  Some of the things in the LXR queries above are in Makefile.in's.

Comment 6

[hacker formerly known as [e-mail]]

Attachment: Remove obsolete CHROME_* references from Makefile.in

Comment 7

[Brian Ryner (not reading)]

Comment on attachment 79590 [details] [diff] [review]
Remove obsolete CHROME_* references from Makefile.in

r=bryner

Comment 8

[hacker formerly known as [e-mail]]

Makefile.in patch has been checked in on the trunk.  It still needs to be
checked in on the branch...as do the equivalent nmake changes since nmake is
going to live for a bit longer on the branch. 

Comment 9

[hacker formerly known as [e-mail]]

http://mpt.phrasewise.com/2002/06/07