Closed Bug 113401 Opened 23 years ago Closed 22 years ago

remove obsolete chrome rules from Makefiles

Categories

(SeaMonkey :: Build Config, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.1alpha

People

(Reporter: dbaron, Assigned: netscape)

References

Details

Attachments

(1 file)

I'm told that after warren landed jarring, not all the old rules were removed
from the makefiles.  These remaining rules from the makefiles make it very
confusing to figure out what needs to be done to add chrome files -- or figure
out what went wrong when the tree is broken because somebody did it wrong.

It's been suggested to me that all of these are obsolete (and even builds
without JAR packaging use the jar.mn), but I'm not really sure:

http://lxr.mozilla.org/seamonkey/search?string=CHROME_CONTENT
http://lxr.mozilla.org/seamonkey/search?string=CHROME_DIR (excl. "$chrome_dir")

There are probably also some makefiles in directories that we don't descend into
and makefiles that we don't need to descend into that could be cleaned up,
although perhaps that should be a separate bug.
(I might even be willing to help do this if somebody assures me what's safe and
what isn't...)
Bryner did some cleanup on the unix side a while ago.  IIRC, all CHROME_*
variables can be purged. They are definitely not used in the unix side.  On
win32, the old MOZ_OLD_JAR_PACKAGING ifdefs in rules.mak will need to be removed
before the aforementioned variables can be purged.
Priority: -- → P4
Target Milestone: --- → mozilla0.9.9
nmake is dead. long live gmake.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WONTFIX
and so it begins.

verified wontfix.
Status: RESOLVED → VERIFIED
Hold on a sec.  Some of the things in the LXR queries above are in Makefile.in's.
Status: VERIFIED → REOPENED
Resolution: WONTFIX → ---
Target Milestone: mozilla0.9.9 → mozilla1.1alpha
Comment on attachment 79590 [details] [diff] [review]
Remove obsolete CHROME_* references from Makefile.in

r=bryner
Attachment #79590 - Flags: review+
Makefile.in patch has been checked in on the trunk.  It still needs to be
checked in on the branch...as do the equivalent nmake changes since nmake is
going to live for a bit longer on the branch. 
Status: REOPENED → ASSIGNED
Whiteboard: [fixed on trunk]
Target Milestone: mozilla1.1alpha → mozilla1.0.1
Whiteboard: [fixed on trunk] → [fixed on trunk][drivers queue]
http://mpt.phrasewise.com/2002/06/07
Status: ASSIGNED → RESOLVED
Closed: 23 years ago22 years ago
Resolution: --- → FIXED
Whiteboard: [fixed on trunk][drivers queue]
Target Milestone: mozilla1.0.1 → mozilla1.1alpha
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: