Closed Bug 1134025 Opened 5 years ago Closed 5 years ago

[Customizer] Implement edit element "Properties" and "Attributes" panels

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: drs, Assigned: justindarc)

References

Details

(Whiteboard: [spark])

User Story

Todo:
1. Add handling for an "inspectionRoot" key to the `<gaia-property-inspector>` element's `set()` function, which provides the following functionality:
  a. If unset, we inspect the `properties` root of the targeted element.
  b. If set, we inspect the `properties[inspectionRoot]` attribute.
  c. Does not allow the user to go above the hierarchy beyond the root, whatever that may be.
    i. Hides the "up in hierarchy" button when the user can't go further up in the hierarchy.
2. Add descending sorting of properties/attributes that are set to [non-default, default] values.
3. Add "-" icons next to properties/attributes that are set to non-default values. These icons reset the target property/attribute back to its default value and alter the sorting accordingly.
4. Add a search bar to the top of the "Properties" and "Attributes" views, which live-filters properties and attributes by the search parameters.

Attachments

(1 file)

Amy, this could use some UX/VD feedback. Please see my mocks for additional suggestions:
https://dl.dropboxusercontent.com/u/17593665/Customizer%202.pdf

Here are some recommendations from these mocks that we could use, but that need some feedback first:
5. Add an "Add new (property|attribute)" button to the bottom of the "Properties" and "Attributes" views.
6. Add a "Show all / Hide all" toggle to the unset properties and attributes.
Flags: needinfo?(amlee)
(In reply to Doug Sherk (:drs) (use needinfo?) from comment #0)
> Amy, this could use some UX/VD feedback. Please see my mocks for additional
> suggestions:
> https://dl.dropboxusercontent.com/u/17593665/Customizer%202.pdf
> 
> Here are some recommendations from these mocks that we could use, but that
> need some feedback first:
> 5. Add an "Add new (property|attribute)" button to the bottom of the
> "Properties" and "Attributes" views.
> 6. Add a "Show all / Hide all" toggle to the unset properties and attributes.

Flagging Jacqueline for UX feedback
Flags: needinfo?(amlee) → needinfo?(jsavory)
User Story: (updated)
I've attached a proposal for how adding an attribute or property could work. Let me know if this makes sense and/or if there are any questions.
Flags: needinfo?(jsavory)
Priority: -- → P1
Whiteboard: [lightsaber]
Comment on attachment 8566312 [details]
AddAttribute_Concept.pdf

Jacqueline, you may want to search without necessarily adding a new attribute. I also think that for educational purposes, being able to view the list of all attributes without having to go into the "add attribute" path helps users fool around without being worried that they'll do damage.
Flags: needinfo?(jsavory)
Depends on: 1134021
Closing this. We don't have the ability to return an attribute/property to its "default" value yet as there's no easy way to determine what its default value should be. Other than that, every other aspect of these two panes is completed. Filing a follow-up for resetting values to "default" once a suitable algorithm is determined for figuring that out.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
See Also: → 1137887
Removing flag as this has been fixed and UX questions were discussed and will be answered in the next IxD spec.
Flags: needinfo?(jsavory)
Whiteboard: [lightsaber] → [ignite]
Whiteboard: [ignite] → [spark]
You need to log in before you can comment on or make changes to this bug.