1134038 - [Contacts] Adding/Deleting fields from editing a contact doesn't require tapping the '+' or 'x' buttons

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Oliver Nelson [:oliverthor]]

Attachment: logcat_20150217_1523.txt

Description:
When the user is creating a contact, or editing an existing one, they will observe the multiple fields that exist along the page. When the user taps the '+' sign, they will add a field row, according to the text of the row that was tapped. If the user taps anywhere on the bar, they will also observe that the field will create a new row. This is disorienting to a user as they may be trying to scroll through creating a contact and tap the bars to create new fields accidentally. When removing a field as well, the user is encouraged to tap the 'x' button to remove said field. However, they may tap in any space underneath the 'x' button as well to remove it from the contact. This is most noteable in the 'Address' field as there is a large amount of blank space a user may accidentally tap.


Repro Steps:
1) Update a Flame to 20150217074222
2) Open the 'Contacts' app.
3) Tap the '+' to create a new contact.
4) Tap the bar of a field to the right of the text "Add Phone/Email/Address".
5) On an existing field, tap under the 'x' to remove the field.


Actual:
User may remove and add fields from editing a contact without tapping the associated buttons.

Expected:
User may tap the '+' and 'x' buttons to add and remove fields from an in-progress contact respectively.



Environmental Variables:
--------------------------------------------------
Device: Flame 3.0
Build ID: 20150217074222
Gaia: ae02fbdeae77b2002cebe33c61aedeee4b9439fd
Gecko: 4bb425001d8a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Device: Flame 2.2
BuildID: 20150217002515
Gaia: ea64caf6d4ab03fc4472eca9f41f20d651d55fa9
Gecko: 78d823f7be4c
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 2.1
BuildID: 20150217001459
Gaia: e8eba437af02820f74d122aec83b6001df6f89e3
Gecko: 9d04f9149ca4
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Additional Behaviour: [2.1 does highlight the entire '+ Add *' row when adding new rows.]
--------------------------------------------------
--------------------------------------------------
Issue DOES NOT REPRO on 2.0 for flame devices [different UI]:
Results: Tap the '+' to create a new field; tap the 'X' to disable new fields; tap the spiral arrow to revive disabled fields.

Device: Flame 2.0
BuildID: 20150217000203
Gaia: ecb1bbc3b9c00f82df172427f65d6f67e34ed533
Gecko: 3051696eafcc
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 32.0 (2.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
--------------------------------------------------


Repro frequency: 10/10
See attached: 
video
logcat

Comment 1

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

I think we need some UX input here.

Comment 2

[Carrie Wang [New account: [e-mail]]]

Actually I think this is the way how the engineer implement the function. I'm fine with either making it tappable only on the buttons or just keeping it as current behavior. ni? Jose for some rationale behind the scene. Thanks!

Comment 3

[Jose Manuel Cantera]

It can be possible to restrict the clickable area only to the '+' or 'x' buttons but I would not recommend it, as it would be a really small target. As a result we would need to make the clickable area bigger than the button dimensions. On the other hand, the likelihood of generating a click while scrolling is certainly low IMHO.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

I do agree with comment 3, Carrie should we close it as worksforme?

Comment 5

[Carrie Wang [New account: [e-mail]]]

Sure. we may fix this in the future with our new v3 design. Thanks!