Closed Bug 113404 Opened 23 years ago Closed 22 years ago

unnecessary big memcpy in nsZipArchive::InflateItem

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED DUPLICATE of bug 189528

People

(Reporter: dveditz, Assigned: dveditz)

Details

nsZipArchive::InflateItem does an extra memcpy of every file's content when it's inflating into a buffer instead of a file (the usual case). It could use the allocated buffer directly in the inflate step.
It would be good to measure the improvement if this is a lot of time sink. Gut feel is this could save about 215 memcpy of <filesize> and all files we read on startup arent that big (< 4k). Let me know if you want me to help measure the cost. If it is an easy thing to fix, go ahead.
Status: NEW → ASSIGNED
This 'bug' has been solved not so long ago, and should be closed. See bug 189528. *** This bug has been marked as a duplicate of 189528 ***
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → DUPLICATE
yup.
Status: RESOLVED → VERIFIED
Component: XP Miscellany → General
QA Contact: brendan → general
You need to log in before you can comment on or make changes to this bug.