1134056 - Tasks in defined state should not create treeherder symbols

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[James Lal [:lightsofapollo]]

I am fairly convinced now that we should only output symbols for tasks in states other then pending... Right now if the build fails (or any higher level task) we end up in a weird situation where we see symbols that will never be run.

Comment 1

[Jonas Finnemann Jensen (:jonasfj)]

So just a note on this topic:

In buildbot the symbols first appear then the job is pending.
This is because nobody knows exactly what buildbot is going to run.

The semantics you achieve by not outputting symboles for tasks before they are pending, is exactly the semantics exhibited by buildbot. The only difference is that buildbot has these semantics because of technical limitations. Now that you have the option to choose your semantics, you might want to reconsider if the original behaviour is desired or merely a result of technical limitations.

I suspect original behaviour is a result of technical limitations.

Notice that if treeherder shows tasks before they are pending, it's easier to see just how close to complete your try-push is.
Where as with buildbot semantics of only showing tasks when they become pending, you can be repeatedly surprised by new tasks that just magically appears.

I suggests you ask someone who knows how they want to work. And is willing to modify treeherder, which is obviously designed the buildbot semantics in mind.
(Personally I don't really care, it's a detail we can easily change any time).

Comment 2

[James Lal [:lightsofapollo]]

landed https://github.com/taskcluster/mozilla-taskcluster/commit/c32a1450d5ce9a2fbd96ec0d3f3aed7ad3f74204

Comment 3

[Pete Moore [:pmoore][:pete]]

Resetting Version and Target Milestone that accidentally got changed...