Closed Bug 1134120 Opened 10 years ago Closed 9 years ago

Intermittent parse-a-sizes-attribute.html | <img srcset="data:,a 300w, data:,b 301w"> ref sizes="100vw" (standards mode) - assert_unreached: ref currentSrc was null Reached unreachable code

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
Windows 8
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox48 --- fixed

People

(Reporter: cbook, Assigned: edgar)

References

(
URL
)

Details

(Keywords: intermittent-failure, Whiteboard: [tw-dom])

Attachments

(1 file)

Enable parse-a-sizes-attribute.html test and update meta data, v1
69.61 KB, patch
jdm
: review+
Details | Diff | Splinter Review
Windows 8 64-bit mozilla-central opt test web-platform-tests-3 https://treeherder.mozilla.org/logviewer.html#?job_id=1047866&repo=mozilla-central 20:35:00 INFO - TEST-UNEXPECTED-FAIL | /html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html | <img srcset="data:,a 300w, data:,b 301w"> ref sizes="100vw" (standards mode) - assert_unreached: ref currentSrc was null Reached unreachable code
Component: SVG → Layout: Images
Flags: needinfo?(josh)
Also note, that the default value of img.currentSrc should be an empty string and not null. (It's a little bit different to mediaelement.currentSrc)
I can reproduce this locally. It seems like something causes the image to not load at all sometimes. currentSrc is null for all images in some iframes (only the "standards mode" iframe?) sometimes. (I can't reproduce with the network tab open in devtools.)
(In reply to Simon Pieters from comment #45) > I can reproduce this locally. > > It seems like something causes the image to not load at all sometimes. > currentSrc is null for all images in some iframes (only the "standards mode" > iframe?) sometimes. > > (I can't reproduce with the network tab open in devtools.) See also bug 1135515, something fishy happening here.
status-firefox-esr38: fixed → ---
Flags: needinfo?(josh)
Whiteboard: [test disabled]
Component: Layout: Images → DOM
Whiteboard: [test disabled] → [test disabled] [tw-dom]
Assignee: nobody → echen
Blocks: 1017878
I would like to investigate the intermittent-failures on parse-a-sizes-attribute.html. But I cannot reproduce the failures locally any more. I could not reproduce on try [1] with a lot of retriggers, either. It looks like this failure isn't existed any more. So I would like to enable parse-a-sizes-attribute.html back. (BTW, The test contents are different now, the meta data needs to be updated.) [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc790ba8cc33c614b586c5d791f0d14477ca6d26&group_state=expanded
Comment on attachment 8738418 [details] [diff] [review] Enable parse-a-sizes-attribute.html test and update meta data, v1 Review of attachment 8738418 [details] [diff] [review]: ----------------------------------------------------------------- Please see comment #61 for the details. Thank you.
Attachment #8738418 - Flags: review?(josh)
Comment on attachment 8738418 [details] [diff] [review] Enable parse-a-sizes-attribute.html test and update meta data, v1 Review of attachment 8738418 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for checking!
Attachment #8738418 - Flags: review?(josh) → review+
Keywords: leave-open → checkin-needed
Whiteboard: [test disabled] [tw-dom] → [tw-dom]
https://hg.mozilla.org/mozilla-central/rev/85a2d1e3cf95
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: