Closed Bug 1134206 Opened 10 years ago Closed 10 years ago

CSS Ruby line spacing adjustment doesn't happen in quirks mode

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38
Tracking Flags:
Tracking Status
firefox38 --- fixed

People

(Reporter: xmomdo, Assigned: xidorn)

Details

(Keywords: css3)

Attachments

(2 files, 1 obsolete file)

patch 1 - Remove useless field in PSD
5.25 KB, patch
roc
: review+
Details | Diff | Splinter Review
patch 2 - Reset zero effective span box when line spacing is adjusted
3.78 KB, patch
roc
: review+
Details | Diff | Splinter Review
User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0 Build ID: 20150122214805 Steps to reproduce: Writing following HTML fragment: <ul> <li><ruby><rb>上<rb>手<rt>じよう<rt>ず</ruby> <li><ruby><rb>旧<rb>金<rb>山<rt>jiù<rt>jīn<rt>shān</ruby> <li><ruby>東<rb>京<rp>(<rt>とう<rt>きょう<rp>)</ruby> </ul> Actual results: Ruby texts overlap preceding line. (Maybe, This bug has font-dependence. 'MS PGothic' is baggy, 'Meiryo' is narrowly OK.) Expected results: Ruby texts do not overlap precide line.
Component: Untriaged → Layout
Keywords: css3
OS: Windows 8.1 → All
Product: Firefox → Core
Hardware: x86_64 → All
Doesn't this also happen for just blocks? So like this: <div><ruby><rb>上<rb>手<rt>じよう<rt>ず</ruby></div> <div><ruby><rb>旧<rb>金<rb>山<rt>jiù<rt>jīn<rt>shān</ruby></div> <div><ruby>東<rb>京<rp>(<rt>とう<rt>きょう<rp>)</ruby></div>
Interesting that adding <!DOCTYPE html> to the top of the code solves this problem, which means it is a bug in quirk mode I guess.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: CSS Ruby overlaps preceding line on HTML lists → CSS Ruby line spacing adjustment doesn't happen in quirks mode
Assignee: nobody → quanxunzhen
Attachment #8566178 - Flags: review?(roc)
I guess we probably should move the line spacing adjustment to a virtual method of nsIFrame?
Attachment #8566182 - Flags: review?(roc)
Add reftest in addition
Attachment #8566182 - Attachment is obsolete: true
Attachment #8566182 - Flags: review?(roc)
Attachment #8566203 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/bd2675bc4b96 https://hg.mozilla.org/mozilla-central/rev/69e2817c85e8
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox38: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: