Closed Bug 1134231 Opened 6 years ago Closed 6 years ago
Use screenshot event to generate a bug report
47 bytes, text/x-github-pull-request
|Details | Review|
Ultimately, I'm looking for an easy way to send a screen shot of an issue out. Because that's usually the best, visual way of saying 'something ain't quite right'. I also like the idea of shaking the device to create an action. Here are some ideas - thoughts? When I shake my device, then: * I have an option to take a screen shot, then launch an email with pre-populated feedback email address and pre-populated subject line containing 'feedback on iOS client version <>' where we can dynamically insert the client version * Also possible but less easy: proactively take a screen shot then shake the device to send the email (as above) NB - I'm less keen on launching a bugzilla page just because it's so not responsive to the small screen and we can't automatically attach screen shots to the bug (unless I'm wrong)? Karen
> I'm looking for an easy way to send a screen shot of an issue out. Power button and home button same time to capture an iOS screenshot. I don't want to shake (non-standard in Apple) my device to file bug reports. It's a $600 device that will crack on the hardwood. > NB - I'm less keen on launching a bugzilla page just because it's so not responsive to the small screen and we can't automatically attach screen shots to the bug (unless I'm wrong)? You can upload an attachment from Camera Roll, but really this should be done on a computer to have a better detailed bug-report.
yes, we know *how* to take a screen shot, but it's how we get that screen shot over to us in a way that has low barrier to entry (low friction) is the intent here! I believe Darrin or Stefan mentioned that Apple already supports shaking, which is lovely. If there's another key combination that we can use that doesn't involve physical violence against your device, I'm all ears - although I suspect a nice little 'shake' would do nicely. uploading into bugzilla from your device is a HARDSHIP. I've been forced to do it a few times, and I hate it. We just won't get good feedback unless we can lower that barrier to submit, hence trying to find an alternative (fine with email as we can have non-QA eyes watching the email address for action).
Hey there, As of iOS 7, the application can now listen for screenshot events: https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIApplication_Class/#//apple_ref/c/data/UIApplicationUserDidTakeScreenshotNotification. A good starting point for this feature would be to show the new email screen with the screenshot attached and the subject field prepopulated when this notification gets fired. It would also avoid the need to knock sense into your phone :)
Patch/PR Submitted: https://github.com/mozilla/firefox-ios/pull/170
Love the concept and the idea. BTW (and I don't read code as a matter of course, so asking!) - I presume that this only happens when you take a screen shot within the Firefox client app only and not when you take a screenshot outside of the app? Thanks!
Yup that's correct - it will only work while within the Firefox client app.
Stephan this is a great patch. I think this is a good start. Can you conditionally compile this code in like this: https://github.com/mozilla/firefox-ios/commit/5070e159090f972ae5f20e45a7b35696262502e9 (MOZ_CHANNEL_AURORA will not be set yet, but I'll merge that later today - should not matter though) S.
Thanks Stefan! I've updated the PR with the MOZ_CHANNEL_AURORA Flag and rebased your changes off master.
Summary: shake the device to generate a bug report → Use screenshot event to generate a bug report
I merged this in. Thanks you so much for the contribution.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Attachment #8568083 - Flags: review?(sarentz) → review+
Follow-up item at the end of the PR. Posting it here so it doesn't get lost: > Before this PR goes into the filing bin, just a quick note that > AppDelegate.swift:L95 still needs an email to be filled in. > Yeah I'm asking our product manager to provide the email and a > small piece of template text that we can put in the email by default.
I already changed the email to our official feedback email that we gave to our internal testers.
Can we dynamically pull in the build # into the subject line so it corresponds to the correct build? If not, let's just remove the version number from the subject line so no one gets overly confused :)
It already does. The subject line reads: Feedback on iOS client version v1.0 (5) S.
aye aye aye. right. Thanks :/
You need to log in before you can comment on or make changes to this bug.